[libvirt] [PATCH 3/3] qemu: block: Remove misleading part of comment in qemuBlockStorageSourceBuildJSONSocketAddress

Peter Krempa posted 3 patches 7 years, 3 months ago
There is a newer version of this series
[libvirt] [PATCH 3/3] qemu: block: Remove misleading part of comment in qemuBlockStorageSourceBuildJSONSocketAddress
Posted by Peter Krempa 7 years, 3 months ago
The array indexes are formatted if the JSON->commandline translator is
translating an array type. It does not at all depend on this function.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_block.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index eb63139ca0..3f37483c1e 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -472,11 +472,6 @@ qemuBlockStorageSourceGetURI(virStorageSourcePtr src)
  * Formats @hosts into a json object conforming to the 'SocketAddress' type
  * in qemu.
  *
- * This function can be used when only 1 src->nhosts is expected in order
- * to build a command without the array indices after "server.". That is
- * to see "server.type", "server.host", and "server.port" instead of
- * "server.#.type", "server.#.host", and "server.#.port".
- *
  * Returns a virJSONValuePtr for a single server.
  */
 static virJSONValuePtr
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/3] qemu: block: Remove misleading part of comment in qemuBlockStorageSourceBuildJSONSocketAddress
Posted by Ján Tomko 7 years, 2 months ago
On Mon, Feb 12, 2018 at 04:21:00PM +0100, Peter Krempa wrote:
>The array indexes are formatted if the JSON->commandline translator is
>translating an array type. It does not at all depend on this function.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_block.c | 5 -----
> 1 file changed, 5 deletions(-)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list