[libvirt] [PATCH 2/7] nwfilter: remove pointless assignment

Ján Tomko posted 7 patches 7 years, 9 months ago
Only 6 patches received!
[libvirt] [PATCH 2/7] nwfilter: remove pointless assignment
Posted by Ján Tomko 7 years, 9 months ago
Changing a parameter passed by value has no effect.

Introduced by <commit 3f74b2eb>.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/nwfilter/nwfilter_gentech_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c
index 840d419bb..5ef26b6af 100644
--- a/src/nwfilter/nwfilter_gentech_driver.c
+++ b/src/nwfilter/nwfilter_gentech_driver.c
@@ -360,7 +360,6 @@ virNWFilterRuleDefToRuleInst(virNWFilterDefPtr def,
                            inst->nrules,
                            ruleinst) < 0)
         goto cleanup;
-    inst = NULL;
 
     ret = 0;
  cleanup:
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/7] nwfilter: remove pointless assignment
Posted by Peter Krempa 7 years, 9 months ago
On Tue, Mar 06, 2018 at 15:01:34 +0100, Ján Tomko wrote:
> Changing a parameter passed by value has no effect.
> 
> Introduced by <commit 3f74b2eb>.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/nwfilter/nwfilter_gentech_driver.c | 1 -
>  1 file changed, 1 deletion(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list