[libvirt] [PATCH 4/7] virsh-edit: remove unreachable break

Ján Tomko posted 7 patches 7 years, 2 months ago
Only 6 patches received!
[libvirt] [PATCH 4/7] virsh-edit: remove unreachable break
Posted by Ján Tomko 7 years, 2 months ago
Introduced by <commit 1bb1de8>.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-edit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/virsh-edit.c b/tools/virsh-edit.c
index 92a00b7f9..d97794fed 100644
--- a/tools/virsh-edit.c
+++ b/tools/virsh-edit.c
@@ -138,7 +138,6 @@ do {
                 EDIT_RELAX;
                 relax_avail = false;
                 goto redefine;
-                break;
             }
             ATTRIBUTE_FALLTHROUGH;
 #endif
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/7] virsh-edit: remove unreachable break
Posted by Peter Krempa 7 years, 2 months ago
On Tue, Mar 06, 2018 at 15:01:36 +0100, Ján Tomko wrote:
> Introduced by <commit 1bb1de8>.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>

You don't need to overdo it. The commit hook looks for just one.

> ---
>  tools/virsh-edit.c | 1 -
>  1 file changed, 1 deletion(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/7] virsh-edit: remove unreachable break
Posted by Laine Stump 7 years, 2 months ago
On 03/06/2018 09:21 AM, Peter Krempa wrote:
> On Tue, Mar 06, 2018 at 15:01:36 +0100, Ján Tomko wrote:
>> Introduced by <commit 1bb1de8>.
>>
>> Signed-off-by: Ján Tomko <jtomko@redhat.com>
>> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> You don't need to overdo it. The commit hook looks for just one.

He repeatedly pushes the "Close Door" button on elevators too. At least
when I'm running to catch it, anyway...

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list