[libvirt] [PATCH 1/7] maint: use parentheses after if

Ján Tomko posted 7 patches 7 years, 2 months ago
Only 6 patches received!
[libvirt] [PATCH 1/7] maint: use parentheses after if
Posted by Ján Tomko 7 years, 2 months ago
Some instances of ARCH_IS_PPC64 did not use them.

Introduced by commits da636d8 and ef08a54

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 src/qemu/qemu_domain.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a248d73de..115550985 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14738,7 +14738,7 @@ virDomainVideoDefaultType(const virDomainDef *def)
         if (def->os.type == VIR_DOMAIN_OSTYPE_XEN ||
             def->os.type == VIR_DOMAIN_OSTYPE_LINUX)
             return VIR_DOMAIN_VIDEO_TYPE_XEN;
-        else if ARCH_IS_PPC64(def->os.arch)
+        else if (ARCH_IS_PPC64(def->os.arch))
             return VIR_DOMAIN_VIDEO_TYPE_VGA;
         else
             return VIR_DOMAIN_VIDEO_TYPE_CIRRUS;
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 8b4efc82d..687a2d6b5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -5154,7 +5154,7 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
 
     if (dev->type == VIR_DOMAIN_DEVICE_VIDEO) {
         if (dev->data.video->type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) {
-            if ARCH_IS_PPC64(def->os.arch)
+            if (ARCH_IS_PPC64(def->os.arch))
                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VGA;
             else if (qemuDomainIsVirt(def))
                 dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_VIRTIO;
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/7] maint: use parentheses after if
Posted by Peter Krempa 7 years, 2 months ago
On Tue, Mar 06, 2018 at 15:01:33 +0100, Ján Tomko wrote:
> Some instances of ARCH_IS_PPC64 did not use them.
> 
> Introduced by commits da636d8 and ef08a54
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/conf/domain_conf.c | 2 +-
>  src/qemu/qemu_domain.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list