[libvirt] [PATCH v1 1/7] qemu: Fix comment for 'qemuValidateDevicePCISlotsChipsets'

Farhan Ali posted 7 patches 7 years, 2 months ago
There is a newer version of this series
[libvirt] [PATCH v1 1/7] qemu: Fix comment for 'qemuValidateDevicePCISlotsChipsets'
Posted by Farhan Ali 7 years, 2 months ago
There is no function 'qemuValidateDevicePCISlotsChipsets', it
should be qemuDomainValidateDevicePCISlotsChipsets.

Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
---
 src/qemu/qemu_domain_address.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 3fcb36a..ae49cf2 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -1815,7 +1815,7 @@ qemuDomainValidateDevicePCISlotsChipsets(virDomainDefPtr def,
  *  - Video (slot 2)
  *
  *  - These integrated devices were already added by
- *    qemuValidateDevicePCISlotsChipsets invoked right before this function
+ *    qemuDomainValidateDevicePCISlotsChipsets invoked right before this function
  *
  * Incrementally assign slots from 3 onwards:
  *
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 1/7] qemu: Fix comment for 'qemuValidateDevicePCISlotsChipsets'
Posted by John Ferlan 7 years, 1 month ago

On 03/08/2018 11:07 AM, Farhan Ali wrote:
> There is no function 'qemuValidateDevicePCISlotsChipsets', it
> should be qemuDomainValidateDevicePCISlotsChipsets.
> 

Commit id '177db487' renamed 'qemuValidateDevicePCISlotsChipsets' to
'qemuDomainValidateDevicePCISlotsChipsets', but didn't adjust comment.

> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_domain_address.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

(I'll push this one shortly)

> diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
> index 3fcb36a..ae49cf2 100644
> --- a/src/qemu/qemu_domain_address.c
> +++ b/src/qemu/qemu_domain_address.c
> @@ -1815,7 +1815,7 @@ qemuDomainValidateDevicePCISlotsChipsets(virDomainDefPtr def,
>   *  - Video (slot 2)
>   *
>   *  - These integrated devices were already added by
> - *    qemuValidateDevicePCISlotsChipsets invoked right before this function
> + *    qemuDomainValidateDevicePCISlotsChipsets invoked right before this function
>   *
>   * Incrementally assign slots from 3 onwards:
>   *
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list