rewrite to use libdbus and some other fixes

[libvirt] [dbus PATCH 10/18] spec: don't use hard-coded system_user

Posted by Pavel Hrdina 7 years, 2 months ago

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 libvirt-dbus.spec.in | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in
index 572300f..87f20d4 100644
--- a/libvirt-dbus.spec.in
+++ b/libvirt-dbus.spec.in
@@ -2,6 +2,7 @@
 
 %define libvirt_version @LIBVIRT_REQUIRED@
 %define systemd_version @SYSTEMD_REQUIRED@
+%define system_user @SYSTEM_USER@
 
 Name: @PACKAGE@
 Version: @VERSION@
@@ -39,10 +40,10 @@ rm -rf $RPM_BUILD_ROOT
 rm -rf $RPM_BUILD_ROOT
 
 %pre
-getent group libvirtdbus >/dev/null || groupadd -r libvirtdbus
-getent passwd libvirtdbus >/dev/null || \
-    useradd -r -g libvirtdbus -d / -s /sbin/nologin \
-    -c "Libvirt DBus bridge" libvirtdbus
+getent group %{system_user} >/dev/null || groupadd -r %{system_user}
+getent passwd %{system_user} >/dev/null || \
+    useradd -r -g %{system_user} -d / -s /sbin/nologin \
+    -c "Libvirt DBus bridge" %{system_user}
 exit 0
 
 %files
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 10/18] spec: don't use hard-coded system_user

Posted by Daniel P. Berrangé 7 years, 2 months ago

On Mon, Mar 12, 2018 at 05:21:40PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  libvirt-dbus.spec.in | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list