[libvirt] [PATCH 2/2] virCommandFDIsSet: Update documentation

Michal Privoznik posted 2 patches 7 years, 3 months ago
[libvirt] [PATCH 2/2] virCommandFDIsSet: Update documentation
Posted by Michal Privoznik 7 years, 3 months ago
The set of arguments was changed a long time ago (040d9963420
which dates back to July 2013)  but the corresponding
documentation was not updated.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/util/vircommand.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 8a319069fd..6dab105f56 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -147,9 +147,8 @@ static int dryRunStatus;
 
 /*
  * virCommandFDIsSet:
- * @fd: FD to test
- * @set: the set
- * @set_size: actual size of @set
+ * @cmd: pointer to virCommand
+ * @fd: file descriptor to query
  *
  * Check if FD is already in @set or not.
  *
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] virCommandFDIsSet: Update documentation
Posted by Daniel P. Berrangé 7 years, 3 months ago
On Wed, Mar 21, 2018 at 05:28:34PM +0100, Michal Privoznik wrote:
> The set of arguments was changed a long time ago (040d9963420
> which dates back to July 2013)  but the corresponding
> documentation was not updated.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/util/vircommand.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/util/vircommand.c b/src/util/vircommand.c
> index 8a319069fd..6dab105f56 100644
> --- a/src/util/vircommand.c
> +++ b/src/util/vircommand.c
> @@ -147,9 +147,8 @@ static int dryRunStatus;
>  
>  /*
>   * virCommandFDIsSet:
> - * @fd: FD to test
> - * @set: the set
> - * @set_size: actual size of @set
> + * @cmd: pointer to virCommand
> + * @fd: file descriptor to query
>   *
>   * Check if FD is already in @set or not.
>   *

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list