[libvirt] [PATCH 4/4] news: Update release news with mediated devices hot {plug, unplug}

Erik Skultety posted 4 patches 7 years, 1 month ago
[libvirt] [PATCH 4/4] news: Update release news with mediated devices hot {plug, unplug}
Posted by Erik Skultety 7 years, 1 month ago
Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 docs/news.xml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 108889574..6075cc9ca 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -92,6 +92,20 @@
           previously started domains to 256, or restart them.
         </description>
       </change>
+      <change>
+        <summary>
+          qemu: Support hot plug and hot unplug with mediated devices
+        </summary>
+        <description>
+          Libvirt now allows mediated devices to be hot plugged and hot
+          unplugged from a guest rather than reporting an error that this isn't
+          supported. In fact, this has been supported with mediated devices
+          since their first appearance in 4.10 kernel. Be ware though that this
+          still doesn't guarantee any functionality with respect to the guest
+          driver which might not cope with a device being hot plugged or
+          unplugged.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/4] news: Update release news with mediated devices hot {plug, unplug}
Posted by Peter Krempa 7 years, 1 month ago
On Tue, Mar 27, 2018 at 10:57:16 +0200, Erik Skultety wrote:
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  docs/news.xml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 108889574..6075cc9ca 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -92,6 +92,20 @@
>            previously started domains to 256, or restart them.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          qemu: Support hot plug and hot unplug with mediated devices

s/with/of/

> +        </summary>
> +        <description>
> +          Libvirt now allows mediated devices to be hot plugged and hot
> +          unplugged from a guest rather than reporting an error that this isn't

The end of the sentence is kind of obvious.

> +          supported. In fact, this has been supported with mediated devices

I'd say 'In fact, kernel supported this ...' so that it's obvious which
component you are speaking of.

> +          since their first appearance in 4.10 kernel. Be ware though that this
> +          still doesn't guarantee any functionality with respect to the guest
> +          driver which might not cope with a device being hot plugged or
> +          unplugged.

As with any hotplug. The drivers in the guest can ignore the device, or
disallow unplug if it is not supported.

If you want to point out that drivers currently don't support it in some
cases, please be more direct.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list