Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT
since it specifies <vmport state=off/>.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +-
 tests/qemuxml2argvtest.c                           | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qemuxml2argvdata/q35-virt-manager-basic.args b/tests/qemuxml2argvdata/q35-virt-manager-basic.args
index 96d2ae5924..c7dd514fec 100644
--- a/tests/qemuxml2argvdata/q35-virt-manager-basic.args
+++ b/tests/qemuxml2argvdata/q35-virt-manager-basic.args
@@ -7,7 +7,7 @@ QEMU_AUDIO_DRV=spice \
 /usr/bin/qemu-system-x86_64 \
 -name virt-manager-basic \
 -S \
--M pc-q35-2.7 \
+-machine pc-q35-2.7,accel=kvm,vmport=off \
 -m 4096 \
 -smp 2,sockets=2,cores=1,threads=1 \
 -uuid 1b826c23-8767-47ad-a6b5-c83a88277f71 \
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index d79913dd0a..5ccbb3cff9 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2384,6 +2384,8 @@ mymain(void)
     DO_TEST("q35-virt-manager-basic",
             QEMU_CAPS_KVM,
             QEMU_CAPS_RTC,
+            QEMU_CAPS_MACHINE_OPT,
+            QEMU_CAPS_MACHINE_VMPORT_OPT,
             QEMU_CAPS_ICH9_DISABLE_S3,
             QEMU_CAPS_ICH9_DISABLE_S4,
             QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY,
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote:
> Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT
> since it specifies <vmport state=off/>.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +-
>  tests/qemuxml2argvtest.c                           | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)

Kinda weird that we don't just error out if vmport is configured
and we clearly have no way of enforcing it.

Regardless,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list