Drop the checking of 'shared' from the ABI stability check. This
property controls whether the hypervisor allows multiple accesses to the
same file, but this fact does not influence guest ABI.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1ae742a110..fdf8930f73 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20819,8 +20819,7 @@ virDomainDiskDefCheckABIStability(virDomainDiskDefPtr src,

     }

-    if (src->src->readonly != dst->src->readonly ||
-        src->src->shared != dst->src->shared) {
+    if (src->src->readonly != dst->src->readonly) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Target disk access mode does not match source"));
         return false;
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Apr 18, 2018 at 12:55:42PM +0200, Peter Krempa wrote:
>Drop the checking of 'shared' from the ABI stability check. This
>property controls whether the hypervisor allows multiple accesses to the

s/multiple accesses/concurrent access/ maybe?

>same file, but this fact does not influence guest ABI.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/domain_conf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list