syntax: Require spaces after casts

[libvirt] [PATCH 01/29] admin: Add spaces after casts

Posted by Martin Kletzander 7 years, 7 months ago

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/admin/admin_remote.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/admin/admin_remote.c b/src/admin/admin_remote.c
index b29d109f6a29..56c2e743e45b 100644
--- a/src/admin/admin_remote.c
+++ b/src/admin/admin_remote.c
@@ -172,8 +172,8 @@ remoteAdminConnectOpen(virAdmConnectPtr conn, unsigned int flags)
                                  virObjectFreeCallback);
 
     if (call(conn, 0, ADMIN_PROC_CONNECT_OPEN,
-             (xdrproc_t)xdr_admin_connect_open_args, (char *)&args,
-             (xdrproc_t)xdr_void, (char *)NULL) == -1) {
+             (xdrproc_t)xdr_admin_connect_open_args, (char *) &args,
+             (xdrproc_t)xdr_void, (char *) NULL) == -1) {
         goto done;
     }
 
@@ -193,8 +193,8 @@ remoteAdminConnectClose(virAdmConnectPtr conn)
     virObjectLock(priv);
 
     if (call(conn, 0, ADMIN_PROC_CONNECT_CLOSE,
-             (xdrproc_t)xdr_void, (char *)NULL,
-             (xdrproc_t)xdr_void, (char *)NULL) == -1) {
+             (xdrproc_t)xdr_void, (char *) NULL,
+             (xdrproc_t)xdr_void, (char *) NULL) == -1) {
         goto done;
     }
 
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/29] admin: Add spaces after casts

Posted by Peter Krempa 7 years, 7 months ago

On Mon, Apr 23, 2018 at 14:44:29 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  src/admin/admin_remote.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/admin/admin_remote.c b/src/admin/admin_remote.c
> index b29d109f6a29..56c2e743e45b 100644
> --- a/src/admin/admin_remote.c
> +++ b/src/admin/admin_remote.c
> @@ -172,8 +172,8 @@ remoteAdminConnectOpen(virAdmConnectPtr conn, unsigned int flags)
>                                   virObjectFreeCallback);
>  
>      if (call(conn, 0, ADMIN_PROC_CONNECT_OPEN,
> -             (xdrproc_t)xdr_admin_connect_open_args, (char *)&args,
> -             (xdrproc_t)xdr_void, (char *)NULL) == -1) {
> +             (xdrproc_t)xdr_admin_connect_open_args, (char *) &args,
> +             (xdrproc_t)xdr_void, (char *) NULL) == -1) {

                ^^^^^^^^^^^ This also looks like a cast ;)

>          goto done;
>      }
>  
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/29] admin: Add spaces after casts

Posted by Martin Kletzander 7 years, 7 months ago

On Mon, Apr 23, 2018 at 02:52:01PM +0200, Peter Krempa wrote:
>On Mon, Apr 23, 2018 at 14:44:29 +0200, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> ---
>>  src/admin/admin_remote.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/admin/admin_remote.c b/src/admin/admin_remote.c
>> index b29d109f6a29..56c2e743e45b 100644
>> --- a/src/admin/admin_remote.c
>> +++ b/src/admin/admin_remote.c
>> @@ -172,8 +172,8 @@ remoteAdminConnectOpen(virAdmConnectPtr conn, unsigned int flags)
>>                                   virObjectFreeCallback);
>>
>>      if (call(conn, 0, ADMIN_PROC_CONNECT_OPEN,
>> -             (xdrproc_t)xdr_admin_connect_open_args, (char *)&args,
>> -             (xdrproc_t)xdr_void, (char *)NULL) == -1) {
>> +             (xdrproc_t)xdr_admin_connect_open_args, (char *) &args,
>> +             (xdrproc_t)xdr_void, (char *) NULL) == -1) {
>
>                ^^^^^^^^^^^ This also looks like a cast ;)
>

Oh shoot, it does.  And a freakin' obvious one indeed.  I remember adding
anything that ends with '_t' to the list of types that we cast, so I must've
left it somwhere.  I'll dig up the differences, add it here, resend the series
and then get nacked by jtomko, I guess.

Thanks.--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list