qemu: Add formatting of JSON objects for -blockdev (blockdev-add saga)

[libvirt] [PATCH 06/35] qemu: block: Handle iomode property for json 'file' driver

Posted by Peter Krempa 7 years ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_block.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index e7bd6c909d..6cf41cf544 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -977,11 +977,17 @@ qemuBlockStorageSourceGetSshProps(virStorageSourcePtr src)
 static virJSONValuePtr
 qemuBlockStorageSourceGetFileProps(virStorageSourcePtr src)
 {
+    const char *iomode = NULL;
     virJSONValuePtr ret = NULL;

+    if (src->iomode != VIR_DOMAIN_DISK_IO_DEFAULT)
+        iomode = virDomainDiskIoTypeToString(src->iomode);
+
     ignore_value(virJSONValueObjectCreate(&ret,
                                           "s:driver", "file",
-                                          "s:filename", src->path, NULL) < 0);
+                                          "s:filename", src->path,
+                                          "S:aio", iomode,
+                                          NULL) < 0);
     return ret;
 }

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 06/35] qemu: block: Handle iomode property for json 'file' driver

Posted by John Ferlan 7 years ago


On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_block.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list