qemu: Add formatting of JSON objects for -blockdev (blockdev-add saga)

[libvirt] [PATCH 20/35] tests: qemublock: Rename variables in anticipation of new tests

Posted by Peter Krempa 7 years ago

New tests will add new data structures so rename the 'data' structure.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemublocktest.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index bd628295ff..7eef9f286a 100644
--- a/tests/qemublocktest.c
+++ b/tests/qemublocktest.c
@@ -117,15 +117,16 @@ static int
 mymain(void)
 {
     int ret = 0;
-    struct testBackingXMLjsonXMLdata data;
+    struct testBackingXMLjsonXMLdata xmljsonxmldata;

     virTestCounterReset("qemu storage source xml->json->xml ");

 #define TEST_JSON_FORMAT(tpe, xmlstr) \
     do { \
-        data.type = tpe; \
-        data.xml = xmlstr; \
-        if (virTestRun(virTestCounterNext(), testBackingXMLjsonXML, &data) < 0) \
+        xmljsonxmldata.type = tpe; \
+        xmljsonxmldata.xml = xmlstr; \
+        if (virTestRun(virTestCounterNext(), testBackingXMLjsonXML, \
+                       &xmljsonxmldata) < 0) \
             ret = -1; \
     } while (0)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 20/35] tests: qemublock: Rename variables in anticipation of new tests

Posted by John Ferlan 7 years ago


On 04/25/2018 11:15 AM, Peter Krempa wrote:
> New tests will add new data structures so rename the 'data' structure.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tests/qemublocktest.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list