The function is not used outside of the src/qemu/qemu_migration_params.c
file so unexport it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_migration_params.c | 30 +++++++++++++++---------------
 src/qemu/qemu_migration_params.h |  5 -----
 2 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 3bbe50a8ed..c5d7ab9016 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -777,6 +777,21 @@ qemuMigrationParamsApply(virQEMUDriverPtr driver,
 }


+static int
+qemuMigrationParamsSetString(qemuMigrationParamsPtr migParams,
+                             qemuMigrationParam param,
+                             const char *value)
+{
+    if (qemuMigrationParamsCheckType(param, QEMU_MIGRATION_PARAM_TYPE_STRING) < 0)
+        return -1;
+
+    if (VIR_STRDUP(migParams->params[param].value.s, value) < 0)
+        return -1;
+
+    return 0;
+}
+
+
 /* qemuMigrationParamsEnableTLS
  * @driver: pointer to qemu driver
  * @vm: domain object
@@ -967,21 +982,6 @@ qemuMigrationParamsFetch(virQEMUDriverPtr driver,
 }


-int
-qemuMigrationParamsSetString(qemuMigrationParamsPtr migParams,
-                             qemuMigrationParam param,
-                             const char *value)
-{
-    if (qemuMigrationParamsCheckType(param, QEMU_MIGRATION_PARAM_TYPE_STRING) < 0)
-        return -1;
-
-    if (VIR_STRDUP(migParams->params[param].value.s, value) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 /**
  * Returns -1 on error,
  *          0 on success,
diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h
index c3484ed1c0..9a865b19f3 100644
--- a/src/qemu/qemu_migration_params.h
+++ b/src/qemu/qemu_migration_params.h
@@ -112,11 +112,6 @@ qemuMigrationParamsFetch(virQEMUDriverPtr driver,
                          int asyncJob,
                          qemuMigrationParamsPtr *migParams);

-int
-qemuMigrationParamsSetString(qemuMigrationParamsPtr migParams,
-                             qemuMigrationParam param,
-                             const char *value);
-
 int
 qemuMigrationParamsGetULL(qemuMigrationParamsPtr migParams,
                           qemuMigrationParam param,
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Apr 27, 2018 at 03:16:45PM +0200, Peter Krempa wrote:
>The function is not used outside of the src/qemu/qemu_migration_params.c
>file so unexport it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_migration_params.c | 30 +++++++++++++++---------------
> src/qemu/qemu_migration_params.h |  5 -----
> 2 files changed, 15 insertions(+), 20 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list