[libvirt] [PATCHv3 13/13] build: require Jansson if QEMU driver is enabled

Ján Tomko posted 13 patches 7 years ago
[libvirt] [PATCHv3 13/13] build: require Jansson if QEMU driver is enabled
Posted by Ján Tomko 7 years ago
If the QEMU driver was requested, require Jansson, since we need to use
the JSON monitor to probe capabilities for all QEMU version supported
by libvirt.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 m4/virt-driver-qemu.m4 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
index ddb2834705..ac80f0cd48 100644
--- a/m4/virt-driver-qemu.m4
+++ b/m4/virt-driver-qemu.m4
@@ -27,6 +27,9 @@ AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
 
 AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [
   AC_REQUIRE([LIBVIRT_CHECK_JANSSON])
+  if test "$with_qemu:$with_jansson" = "yes:no"; then
+    AC_MSG_ERROR([Jansson >= 2.7 is required to build QEMU driver])
+  fi
   if test "$with_qemu" = "check"; then
     with_qemu=$with_jansson
   fi
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCHv3 13/13] build: require Jansson if QEMU driver is enabled
Posted by Peter Krempa 6 years, 12 months ago
On Fri, May 11, 2018 at 14:59:14 +0200, Ján Tomko wrote:
> If the QEMU driver was requested, require Jansson, since we need to use
> the JSON monitor to probe capabilities for all QEMU version supported
> by libvirt.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  m4/virt-driver-qemu.m4 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
> index ddb2834705..ac80f0cd48 100644
> --- a/m4/virt-driver-qemu.m4
> +++ b/m4/virt-driver-qemu.m4
> @@ -27,6 +27,9 @@ AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
>  
>  AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [
>    AC_REQUIRE([LIBVIRT_CHECK_JANSSON])
> +  if test "$with_qemu:$with_jansson" = "yes:no"; then
> +    AC_MSG_ERROR([Jansson >= 2.7 is required to build QEMU driver])
> +  fi

Don't forget to change this to 2.5. ACK I think that it does not make
sense to build a crippled version of the qemu driver.

>    if test "$with_qemu" = "check"; then
>      with_qemu=$with_jansson
>    fi
> -- 
> 2.16.1
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list