New CPU related APIs

[libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

Posted by Jiri Denemark 6 years, 12 months ago

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 tools/virsh.pod | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index 929958a953..5f72e11dec 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -589,7 +589,9 @@ Compare CPU definition from XML <file> with host CPU. The XML <file> may
 contain either host or guest CPU definition. The host CPU definition is the
 <cpu> element and its contents as printed by B<capabilities> command. The
 guest CPU definition is the <cpu> element and its contents from domain XML
-definition. For more information on guest CPU definition see:
+definition. In addition to the <cpu> element itself, this command accepts
+full domain or capabilities XML containing the <cpu> element. For more
+information on guest CPU definition see:
 L<https://libvirt.org/formatdomain.html#elementsCPU>. If I<--error> is
 specified, the command will return an error when the given CPU is
 incompatible with host CPU and a message providing more details about the
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

Posted by Collin Walling 6 years, 11 months ago

On 05/16/2018 04:39 AM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  tools/virsh.pod | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 929958a953..5f72e11dec 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -589,7 +589,9 @@ Compare CPU definition from XML <file> with host CPU. The XML <file> may
>  contain either host or guest CPU definition. The host CPU definition is the
>  <cpu> element and its contents as printed by B<capabilities> command. The
>  guest CPU definition is the <cpu> element and its contents from domain XML
> -definition. For more information on guest CPU definition see:
> +definition. In addition to the <cpu> element itself, this command accepts
> +full domain or capabilities XML containing the <cpu> element. For more
> +information on guest CPU definition see:
>  L<https://libvirt.org/formatdomain.html#elementsCPU>. If I<--error> is
>  specified, the command will return an error when the given CPU is
>  incompatible with host CPU and a message providing more details about the
> 

Reviewed-by: Collin Walling <walling@linux.ibm.com>

-- 
Respectfully,
- Collin Walling

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

Posted by Kashyap Chamarthy 6 years, 11 months ago

On Wed, May 16, 2018 at 10:39:22AM +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  tools/virsh.pod | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 929958a953..5f72e11dec 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -589,7 +589,9 @@ Compare CPU definition from XML <file> with host CPU. The XML <file> may
>  contain either host or guest CPU definition. The host CPU definition is the
>  <cpu> element and its contents as printed by B<capabilities> command. The
>  guest CPU definition is the <cpu> element and its contents from domain XML
> -definition. For more information on guest CPU definition see:
> +definition. In addition to the <cpu> element itself, this command accepts
> +full domain or capabilities XML containing the <cpu> element. For more
> +information on guest CPU definition see:
>  L<https://libvirt.org/formatdomain.html#elementsCPU>. If I<--error> is
>  specified, the command will return an error when the given CPU is
>  incompatible with host CPU and a message providing more details about the

Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>

-- 
/kashyap

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

Posted by Ján Tomko 6 years, 11 months ago

On Wed, May 16, 2018 at 10:39:22AM +0200, Jiri Denemark wrote:
>Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
>---
> tools/virsh.pod | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list