[libvirt] [PATCH 1/5] docs: Tiny fix for the SMM description

Martin Kletzander posted 5 patches 7 years, 6 months ago
[libvirt] [PATCH 1/5] docs: Tiny fix for the SMM description
Posted by Martin Kletzander 7 years, 6 months ago
The default is actually `on` when `<smm/>` is specified.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 docs/formatdomain.html.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 0d0fd3b9f3ea..403b638bd4bd 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2052,9 +2052,9 @@
           <span class="since">Since 1.2.16</span>
       </dd>
       <dt><code>smm</code></dt>
-      <dd>Enable System Management Mode. Possible values are
-          <code>on</code> and <code>off</code>. The default is left
-          for hypervisor to decide.
+      <dd>Depending on the <code>state</code> attribute (values <code>on</code>,
+          <code>off</code>, default <code>on</code>) enable or disable
+          System Management Mode.
           <span class="since">Since 2.1.0</span>
       </dd>
       <dt><code>ioapic</code></dt>
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/5] docs: Tiny fix for the SMM description
Posted by John Ferlan 7 years, 6 months ago

On 05/21/2018 11:00 AM, Martin Kletzander wrote:
> The default is actually `on` when `<smm/>` is specified.
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  docs/formatdomain.html.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

<sigh>, commit id d0e4be9d was wrong w/r/t the default...  Same default
as hap, pmu, pvspinlock, and vmport...

Reviewed-by: John Ferlan <jferlan@redhat.com>

John
(this should be SFF, too)

Not for this patch, but perhaps we should come up with a common way to
state it for each of those in the switch so that it's obvious.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list