Further patches will introduce validation and a default setting
of def->os.bootDevs in postParse.

Introduce a feature flag to opt out of this and set it in the vmx
driver.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/conf/domain_conf.h | 1 +
 src/vmx/vmx.c          | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index b7e52a1e03..e10206b358 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2557,6 +2557,7 @@ typedef enum {
     VIR_DOMAIN_DEF_FEATURE_NAME_SLASH = (1 << 3),
     VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS = (1 << 4),
     VIR_DOMAIN_DEF_FEATURE_USER_ALIAS = (1 << 5),
+    VIR_DOMAIN_DEF_FEATURE_NO_BOOT_ORDER = (1 << 6),
 } virDomainDefFeatures;
 
 
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index df6a58a474..bdc27b15b0 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -550,7 +550,8 @@ static virDomainDefParserConfig virVMXDomainDefParserConfig = {
     .devicesPostParseCallback = virVMXDomainDevicesDefPostParse,
     .domainPostParseCallback = virVMXDomainDefPostParse,
     .features = (VIR_DOMAIN_DEF_FEATURE_WIDE_SCSI |
-                 VIR_DOMAIN_DEF_FEATURE_NAME_SLASH),
+                 VIR_DOMAIN_DEF_FEATURE_NAME_SLASH |
+                 VIR_DOMAIN_DEF_FEATURE_NO_BOOT_ORDER),
 };
 
 struct virVMXDomainDefNamespaceData {
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, May 28, 2018 at 15:54:02 +0200, Ján Tomko wrote:
> Further patches will introduce validation and a default setting
> of def->os.bootDevs in postParse.
> 
> Introduce a feature flag to opt out of this and set it in the vmx
> driver.

This does not clarify in any way why it is required.

> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/conf/domain_conf.h | 1 +
>  src/vmx/vmx.c          | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, May 29, 2018 at 09:30:05AM +0200, Peter Krempa wrote:
>On Mon, May 28, 2018 at 15:54:02 +0200, Ján Tomko wrote:
>> Further patches will introduce validation and a default setting
>> of def->os.bootDevs in postParse.
>>
>> Introduce a feature flag to opt out of this and set it in the vmx
>> driver.
>
>This does not clarify in any way why it is required.
>


Introduce a feature flag to opt out of this and set it in the vmx
driver, otherwise we would be adding it <boot dev='hd'/> into every
vmx config despite having no way to change it.

(Alternatively, if booting from hard-drive is the default, we can just
leave it in because none of the vmx code even touches bootDevs, so
it will be safely ignored)

Jano

>>
>> Signed-off-by: Ján Tomko <jtomko@redhat.com>
>> ---
>>  src/conf/domain_conf.h | 1 +
>>  src/vmx/vmx.c          | 3 ++-
>>  2 files changed, 3 insertions(+), 1 deletion(-)


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, May 29, 2018 at 09:48:51 +0200, Ján Tomko wrote:
> On Tue, May 29, 2018 at 09:30:05AM +0200, Peter Krempa wrote:
> > On Mon, May 28, 2018 at 15:54:02 +0200, Ján Tomko wrote:
> > > Further patches will introduce validation and a default setting
> > > of def->os.bootDevs in postParse.
> > > 
> > > Introduce a feature flag to opt out of this and set it in the vmx
> > > driver.
> > 
> > This does not clarify in any way why it is required.
> > 
> 
> 
> Introduce a feature flag to opt out of this and set it in the vmx
> driver, otherwise we would be adding it <boot dev='hd'/> into every
> vmx config despite having no way to change it.

ACK to the patch if you add this wording.

> 
> (Alternatively, if booting from hard-drive is the default, we can just
> leave it in because none of the vmx code even touches bootDevs, so
> it will be safely ignored)

It very well might be the default. The capability can easily be deleted
later.

> 
> Jano
> 
> > > 
> > > Signed-off-by: Ján Tomko <jtomko@redhat.com>
> > > ---
> > >  src/conf/domain_conf.h | 1 +
> > >  src/vmx/vmx.c          | 3 ++-
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> 



> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list