qemu: Refactor secret/TLS setup and add TLS for nbd

[libvirt] [PATCH 06/38] qemu: domain: Setup disk encryption password secret via new helper

Posted by Peter Krempa 6 years, 11 months ago

The encryption secret is setup only for LUKS and thus requires the new
approach. Use qemuDomainSecretInfoNew for initializing it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 67bf2f6718..d9b10ae96d 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1575,10 +1575,10 @@ qemuDomainSecretStorageSourcePrepare(qemuDomainObjPrivatePtr priv,

     if (hasEnc) {
         if (!(srcPriv->encinfo =
-              qemuDomainSecretInfoNewPlain(priv, encalias,
-                                           VIR_SECRET_USAGE_TYPE_VOLUME, NULL,
-                                           &src->encryption->secrets[0]->seclookupdef,
-                                           true)))
+              qemuDomainSecretInfoNew(priv, encalias,
+                                      VIR_SECRET_USAGE_TYPE_VOLUME, NULL,
+                                      &src->encryption->secrets[0]->seclookupdef,
+                                      true)))
               return -1;
     }

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 06/38] qemu: domain: Setup disk encryption password secret via new helper

Posted by Ján Tomko 6 years, 11 months ago

On Wed, May 30, 2018 at 02:41:02PM +0200, Peter Krempa wrote:
>The encryption secret is setup only for LUKS and thus requires the new
>approach. Use qemuDomainSecretInfoNew for initializing it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_domain.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list