qemu: Refactor secret/TLS setup and add TLS for nbd

[libvirt] [PATCH 24/38] qemu: domain: Forbid TLS setup for disk protocols not supporting it

Posted by Peter Krempa 6 years, 11 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 5e8ff675c8..55e47a482d 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -9971,6 +9971,12 @@ qemuDomainPrepareStorageSourceTLS(virStorageSourcePtr src,
     case VIR_STORAGE_NET_PROTOCOL_FTPS:
     case VIR_STORAGE_NET_PROTOCOL_TFTP:
     case VIR_STORAGE_NET_PROTOCOL_SSH:
+        if (src->haveTLS == VIR_TRISTATE_BOOL_YES) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                           _("TLS transport is not supported for disk protocol '%s'"),
+                           virStorageNetProtocolTypeToString(src->protocol));
+            return -1;
+        }
         break;

     case VIR_STORAGE_NET_PROTOCOL_NONE:
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 24/38] qemu: domain: Forbid TLS setup for disk protocols not supporting it

Posted by Ján Tomko 6 years, 11 months ago

On Wed, May 30, 2018 at 02:41:20PM +0200, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_domain.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list