qemu: Refactor secret/TLS setup and add TLS for nbd

[libvirt] [PATCH 14/38] qemu: hotplug: Use 'tlsAlias' to see whether to detach the disk

Posted by Peter Krempa 6 years, 11 months ago

Using 'haveTLS' to do this is pointless if the alias is not set.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 5e2ca1b988..f8f1d2c323 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -3876,7 +3876,7 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver,
     if (disk->src->pr)
         ignore_value(qemuMonitorDelObject(priv->mon, disk->src->pr->mgralias));

-    if (disk->src->haveTLS)
+    if (disk->src->tlsAlias)
         ignore_value(qemuMonitorDelObject(priv->mon, disk->src->tlsAlias));

     if (qemuDomainObjExitMonitor(driver, vm) < 0)
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 14/38] qemu: hotplug: Use 'tlsAlias' to see whether to detach the disk

Posted by Ján Tomko 6 years, 11 months ago

On Wed, May 30, 2018 at 02:41:10PM +0200, Peter Krempa wrote:
>Using 'haveTLS' to do this is pointless if the alias is not set.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list