qemu: Refactor and simplify handling of disk hotplug and commandline

[libvirt] [PATCH 7/9] qemu: command: Rename qemuBuildDiskDriveCommandLine

Posted by Peter Krempa 6 years, 11 months ago

It prepares all disk so use the plural form.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_command.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 87b043d3f3..118a412ffa 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2231,9 +2231,9 @@ qemuBuildDiskUnmanagedPRCommandLine(virCommandPtr cmd,


 static int
-qemuBuildDiskDriveCommandLine(virCommandPtr cmd,
-                              const virDomainDef *def,
-                              virQEMUCapsPtr qemuCaps)
+qemuBuildDisksCommandLine(virCommandPtr cmd,
+                          const virDomainDef *def,
+                          virQEMUCapsPtr qemuCaps)
 {
     size_t i;
     unsigned int bootCD = 0;
@@ -10096,7 +10096,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver,
     if (qemuBuildHubCommandLine(cmd, def, qemuCaps) < 0)
         goto error;

-    if (qemuBuildDiskDriveCommandLine(cmd, def, qemuCaps) < 0)
+    if (qemuBuildDisksCommandLine(cmd, def, qemuCaps) < 0)
         goto error;

     if (qemuBuildFSDevCommandLine(cmd, def, qemuCaps) < 0)
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 7/9] qemu: command: Rename qemuBuildDiskDriveCommandLine

Posted by Ján Tomko 6 years, 11 months ago

On Fri, Jun 01, 2018 at 05:51:10PM +0200, Peter Krempa wrote:
>It prepares all disk so use the plural form.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_command.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list