It doesn't have any external callers

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/qemu/qemu_command.c | 2 +-
 src/qemu/qemu_command.h | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 20c6ac2a04..4625851dc5 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3352,7 +3352,7 @@ qemuBuildMemoryDeviceStr(virDomainMemoryDefPtr mem)
 }
 
 
-char *
+static char *
 qemuBuildNicStr(virDomainNetDefPtr net,
                 const char *prefix,
                 int vlan)
diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
index da75645ac5..0bcbf3018b 100644
--- a/src/qemu/qemu_command.h
+++ b/src/qemu/qemu_command.h
@@ -92,11 +92,6 @@ char *qemuBuildHostNetStr(virDomainNetDefPtr net,
                           char **vhostfd,
                           size_t vhostfdSize);
 
-/* Legacy, pre device support */
-char *qemuBuildNicStr(virDomainNetDefPtr net,
-                      const char *prefix,
-                      int vlan);
-
 /* Current, best practice */
 char *qemuBuildNicDevStr(virDomainDefPtr def,
                          virDomainNetDefPtr net,
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 06/19/2018 06:40 PM, Cole Robinson wrote:
> It doesn't have any external callers
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  src/qemu/qemu_command.c | 2 +-
>  src/qemu/qemu_command.h | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
> 

Nit pick, I prefer s/qemu: command:/qemu_command/ in $SUBJ, but at the
same time don't care that much. It's a matter of preference after all.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list