tests: qemu: Fix testing QMP commands against the schema

[libvirt] [PATCH 0/6] tests: qemu: Fix testing QMP commands against the schema

Peter Krempa posted 6 patches 5 years, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1531396605.git.pkrempa@redhat.com

Test syntax-check passed

tests/qemumonitorjsontest.c  | 10 ++++++----
tests/qemumonitortestutils.c |  3 ++-
tests/testutilsqemuschema.c  | 10 +++++-----
3 files changed, 13 insertions(+), 10 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/6] tests: qemu: Fix testing QMP commands against the schema

Posted by Peter Krempa 5 years, 9 months ago

I was trying to add some new commands and made a typo. The tests did not
catch it. I must have messed up something when sending the original
schema validation impl.

Peter Krempa (6):
  tests: qemuschema: Fix copy-paste error in function name
  tests: qemuschema: Add line break to debug message
  tests: qemumonitorutils: Don't crash on wrong monitor command
  tests: qemumonitorjson: Raise the necessary debug level for QAPI
    schema checks
  tests: qemumonitorjson: Fix schema testing of monitor commands
  tests: qemumonitorjson: Do QMP schema validation for DO_TEST_GEN

 tests/qemumonitorjsontest.c  | 10 ++++++----
 tests/qemumonitortestutils.c |  3 ++-
 tests/testutilsqemuschema.c  | 10 +++++-----
 3 files changed, 13 insertions(+), 10 deletions(-)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] tests: qemu: Fix testing QMP commands against the schema

Posted by Ján Tomko 5 years, 9 months ago

On Thu, Jul 12, 2018 at 01:58:38PM +0200, Peter Krempa wrote:
>I was trying to add some new commands and made a typo. The tests did not
>catch it. I must have messed up something when sending the original
>schema validation impl.
>
>Peter Krempa (6):
>  tests: qemuschema: Fix copy-paste error in function name
>  tests: qemuschema: Add line break to debug message
>  tests: qemumonitorutils: Don't crash on wrong monitor command
>  tests: qemumonitorjson: Raise the necessary debug level for QAPI
>    schema checks
>  tests: qemumonitorjson: Fix schema testing of monitor commands
>  tests: qemumonitorjson: Do QMP schema validation for DO_TEST_GEN
>
> tests/qemumonitorjsontest.c  | 10 ++++++----
> tests/qemumonitortestutils.c |  3 ++-
> tests/testutilsqemuschema.c  | 10 +++++-----
> 3 files changed, 13 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list