qemu: monitor: Clean up error handling for block job APIs

[libvirt] [PATCH 1/8] qemu: monitor: Remove error classes not conforming to QAPI schema

Posted by Peter Krempa 6 years, 9 months ago

Both were removed prior to qemu v1.2.0-rc0 when switching to the new
error format where almost all error types were converted to GenericError.

Relevant qemu commits are <de253f14912e> and <df1e608a01eb0>

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_monitor_json.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 2921f110a9..7bb3e85229 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -4670,12 +4670,6 @@ qemuMonitorJSONBlockJobError(virJSONValuePtr reply,
     if (qemuMonitorJSONErrorIsClass(error, "DeviceNotActive")) {
         virReportError(VIR_ERR_OPERATION_INVALID,
                        _("No active operation on device: %s"), device);
-    } else if (qemuMonitorJSONErrorIsClass(error, "DeviceInUse")) {
-        virReportError(VIR_ERR_OPERATION_FAILED,
-                       _("Device %s in use"), device);
-    } else if (qemuMonitorJSONErrorIsClass(error, "NotSupported")) {
-        virReportError(VIR_ERR_OPERATION_INVALID,
-                       _("Operation is not supported for device: %s"), device);
     } else if (qemuMonitorJSONErrorIsClass(error, "CommandNotFound")) {
         virReportError(VIR_ERR_OPERATION_INVALID,
                        _("Command '%s' is not found"), cmd_name);
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/8] qemu: monitor: Remove error classes not conforming to QAPI schema

Posted by John Ferlan 6 years, 8 months ago


On 08/15/2018 07:52 AM, Peter Krempa wrote:
> Both were removed prior to qemu v1.2.0-rc0 when switching to the new
> error format where almost all error types were converted to GenericError.
> 
> Relevant qemu commits are <de253f14912e> and <df1e608a01eb0>
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_monitor_json.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list