[libvirt] [PATCH 5/5] tests: pass ULLONG_MAX to qemuMonitorJSONGetBalloonInfo

Ján Tomko posted 5 patches 7 years, 5 months ago
[libvirt] [PATCH 5/5] tests: pass ULLONG_MAX to qemuMonitorJSONGetBalloonInfo
Posted by Ján Tomko 7 years, 5 months ago
Test that we correctly accept 64-bit unsigned numbers for QEMU.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tests/qemumonitorjsontest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 2859d3e82f..36263aad68 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -1515,7 +1515,7 @@ testQemuMonitorJSONqemuMonitorJSONGetBalloonInfo(const void *data)
     if (qemuMonitorTestAddItem(test, "query-balloon",
                                "{"
                                "    \"return\": {"
-                               "        \"actual\": 4294967296"
+                               "        \"actual\": 18446744073709551615"
                                "    },"
                                "    \"id\": \"libvirt-9\""
                                "}") < 0)
@@ -1524,7 +1524,7 @@ testQemuMonitorJSONqemuMonitorJSONGetBalloonInfo(const void *data)
     if (qemuMonitorJSONGetBalloonInfo(qemuMonitorTestGetMonitor(test), &currmem) < 0)
         goto cleanup;
 
-    if (currmem != (4294967296ULL/1024)) {
+    if (currmem != (18446744073709551615ULL/1024)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "Unexpected currmem value: %llu", currmem);
         goto cleanup;
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 5/5] tests: pass ULLONG_MAX to qemuMonitorJSONGetBalloonInfo
Posted by Daniel P. Berrangé 7 years, 5 months ago
On Tue, Aug 28, 2018 at 12:22:55PM +0200, Ján Tomko wrote:
> Test that we correctly accept 64-bit unsigned numbers for QEMU.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  tests/qemumonitorjsontest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list