While looking at how slow this test has gotten,
I found a lost test case, some redundancies.

Thankfully, not running the HostModel functions
twice helped, but there is still room for improvement:
we spend a lot of time in the CPU driver comparing
the same strings over and over again and with over 300
entries in virQEMUCaps enum, we can reduce some of these
string comparisons in the future to cope with more
and more QEMU versions being tested.

Ján Tomko (9):
  tests: drop 'drive' from qemuxml2startup tests
  tests: add macro for dealing with exclusive flags
  tests: introduce macro for qemu XML->startup XML
  tests: only run startup XML tests if requested
  tests: report errors in QEMU XML->startup XML tests
  tests: drop redundant virQEMUCapsFilterByMachineType
  tests: do not mangle real qemu caps in xml2argvtest
  tests: turn skipLegacyCPUs into a flag
  qemu: remove unnecessary virQEMUCapsFreeHostCPUModel

 src/qemu/qemu_capabilities.c                       | 25 +------
 src/qemu/qemu_capspriv.h                           |  5 --
 tests/qemuxml2argvtest.c                           | 76 +++++++++++++---------
 .../{disk-drive-shared.xml => disk-shared.xml}     |  0
 4 files changed, 49 insertions(+), 57 deletions(-)
 rename tests/qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml} (100%)

-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Commit 0bdb704 renamed the corresponding xml->argv tests,
but due to the optimistic nature of xml->startup xml testing,
this test was quietly skipped.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 .../qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml}  | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tests/qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml} (100%)

diff --git a/tests/qemuxml2startupxmloutdata/disk-drive-shared.xml b/tests/qemuxml2startupxmloutdata/disk-shared.xml
similarity index 100%
rename from tests/qemuxml2startupxmloutdata/disk-drive-shared.xml
rename to tests/qemuxml2startupxmloutdata/disk-shared.xml
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 09/09/2018 04:10 AM, Ján Tomko wrote:
> Commit 0bdb704 renamed the corresponding xml->argv tests,
> but due to the optimistic nature of xml->startup xml testing,
> this test was quietly skipped.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  .../qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml}  | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tests/qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml} (100%)
> 
> diff --git a/tests/qemuxml2startupxmloutdata/disk-drive-shared.xml b/tests/qemuxml2startupxmloutdata/disk-shared.xml
> similarity index 100%
> rename from tests/qemuxml2startupxmloutdata/disk-drive-shared.xml
> rename to tests/qemuxml2startupxmloutdata/disk-shared.xml
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list