[libvirt] [PATCH v4 03/23] qemu_security: Require full wrappers for APIs that might touch a file

Michal Privoznik posted 23 patches 6 years, 8 months ago
[libvirt] [PATCH v4 03/23] qemu_security: Require full wrappers for APIs that might touch a file
Posted by Michal Privoznik 6 years, 8 months ago
In the future, the transactions are not going to be optional and
they will be run regardless of domain using namespace to collect
list of paths to be relabeled.

To make sure there won't be an API that goes behind transaction
code back update the comment that serves as decision manual
whether an API must be fully implemented or plain #define is
sufficient.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_security.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_security.h b/src/qemu/qemu_security.h
index c57774deba..ba12eb3caf 100644
--- a/src/qemu/qemu_security.h
+++ b/src/qemu/qemu_security.h
@@ -109,7 +109,7 @@ int qemuSecurityRestoreSavedStateLabel(virQEMUDriverPtr driver,
                                        const char *savefile);
 
 /* Please note that for these APIs there is no wrapper yet. Do NOT blindly add
- * new APIs here. If an API can touch a /dev file add a proper wrapper instead.
+ * new APIs here. If an API can touch a file add a proper wrapper instead.
  */
 # define qemuSecurityCheckAllLabel virSecurityManagerCheckAllLabel
 # define qemuSecurityClearSocketLabel virSecurityManagerClearSocketLabel
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4 03/23] qemu_security: Require full wrappers for APIs that might touch a file
Posted by John Ferlan 6 years, 8 months ago

On 09/10/2018 05:36 AM, Michal Privoznik wrote:
> In the future, the transactions are not going to be optional and
> they will be run regardless of domain using namespace to collect
> list of paths to be relabeled.
> 
> To make sure there won't be an API that goes behind transaction
> code back update the comment that serves as decision manual
> whether an API must be fully implemented or plain #define is
> sufficient.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_security.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list