[libvirt] [snmp PATCH 00/20] Misc cleanups and improvements

Michal Privoznik posted 20 patches 5 years, 7 months ago
Failed in applying to current master (apply log)
.gitignore                 |   1 +
configure.ac               |  31 +-
src/Makefile.am            |  18 -
src/event_poll.c           | 724 -------------------------------------
src/event_poll.h           | 132 -------
src/ignore-value.h         |  64 ----
src/internal.h             | 138 -------
src/libvirtGuestTable.c    |   4 +-
src/libvirtNotifications.h |   8 +-
src/libvirtSnmp.c          | 436 ++++++++--------------
src/libvirtSnmp.h          |  30 +-
src/libvirtSnmpError.c     |  83 ++++-
src/libvirtSnmpError.h     |  23 +-
src/memory.c               | 313 ----------------
src/memory.h               | 212 -----------
src/threads.c              | 251 -------------
src/threads.h              | 101 ------
src/util.c                 | 105 ------
src/util.h                 |  38 --
19 files changed, 261 insertions(+), 2451 deletions(-)
delete mode 100644 src/event_poll.c
delete mode 100644 src/event_poll.h
delete mode 100644 src/ignore-value.h
delete mode 100644 src/internal.h
delete mode 100644 src/memory.c
delete mode 100644 src/memory.h
delete mode 100644 src/threads.c
delete mode 100644 src/threads.h
delete mode 100644 src/util.c
delete mode 100644 src/util.h
[libvirt] [snmp PATCH 00/20] Misc cleanups and improvements
Posted by Michal Privoznik 5 years, 7 months ago
These are not pushed. I'll wait couple of moments if there is somebody
who has opinion. If not I will push them.

Michal Privoznik (20):
  libvirtGuestTable.c: Free duplicated domain name
  libvirtSnmp.c: Retab and realign
  configure: Drop support for libvirt older than 0.9.0
  configure.ac: Drop useless "-lvirt" in LIBVIRT_LIBS
  showError: Switch to less ancient error reporting
  libvirtSnmp: Modernize libvirtSnmpLoadGuests
  libvirtSnmp: Modernize insertGuest
  libvirtSnmp: Rewrite some functions
  src: Fix header file defines
  src: Fix includes in header files
  libvirtRegisterEvents: Drop pthread_attr_init
  libvirtSnmp: turn showError() into printf-like function
  libvirtSnmpError: Drop 'extern' for printLibvirtError()
  libvirtSnmp: Drop 'extern' from function headers
  libvirtSnmp: s/showError/printLibvirtError/
  libvirtSnmpError: Introduce and use printSystemError
  libvirtSnmp: Fix type of libvirtUnregisterEvents()
  libvirtSnmp: Report libvirt errors if no domain is found
  libvirtSnmpInit: Don't report errors from libvirtRegisterEvents()
  .gitignore: Ignore tags file

 .gitignore                 |   1 +
 configure.ac               |  31 +-
 src/Makefile.am            |  18 -
 src/event_poll.c           | 724 -------------------------------------
 src/event_poll.h           | 132 -------
 src/ignore-value.h         |  64 ----
 src/internal.h             | 138 -------
 src/libvirtGuestTable.c    |   4 +-
 src/libvirtNotifications.h |   8 +-
 src/libvirtSnmp.c          | 436 ++++++++--------------
 src/libvirtSnmp.h          |  30 +-
 src/libvirtSnmpError.c     |  83 ++++-
 src/libvirtSnmpError.h     |  23 +-
 src/memory.c               | 313 ----------------
 src/memory.h               | 212 -----------
 src/threads.c              | 251 -------------
 src/threads.h              | 101 ------
 src/util.c                 | 105 ------
 src/util.h                 |  38 --
 19 files changed, 261 insertions(+), 2451 deletions(-)
 delete mode 100644 src/event_poll.c
 delete mode 100644 src/event_poll.h
 delete mode 100644 src/ignore-value.h
 delete mode 100644 src/internal.h
 delete mode 100644 src/memory.c
 delete mode 100644 src/memory.h
 delete mode 100644 src/threads.c
 delete mode 100644 src/threads.h
 delete mode 100644 src/util.c
 delete mode 100644 src/util.h

-- 
2.18.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [snmp PATCH 00/20] Misc cleanups and improvements
Posted by Martin Kletzander 5 years, 7 months ago
On Thu, Oct 18, 2018 at 02:26:38PM +0200, Michal Privoznik wrote:
>These are not pushed. I'll wait couple of moments if there is somebody
>who has opinion. If not I will push them.
>

Except the libvirt-snmp internals this looks good.  Few nits posted for
particular patches, really just nits.

It's a nice clean-up, it definitely makes sense to drop support for too old
libvirt IMHO.

If you want to make the (+)/(-) ratio even smaller you can reorganize some ofthe
patches about error printing and formatting as you are adding some support, then
moving it, then putting it in another function and so on.  But I don't think the
readability is too much impacted by that.  It would just make for a nicer git
history and even more awesome ratio ;)

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list