Use preferred name: 'xen'.
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 19b7312..8043c7c 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -144,8 +144,8 @@
<dd>The content of the <code>type</code> element specifies the
type of operating system to be booted in the virtual machine.
<code>hvm</code> indicates that the OS is one designed to run
- on bare metal, so requires full virtualization. <code>linux</code>
- (badly named!) refers to an OS that supports the Xen 3 hypervisor
+ on bare metal, so requires full virtualization. <code>xen</code>
+ refers to an OS that supports the Xen 3 hypervisor
guest ABI. There are also two optional attributes, <code>arch</code>
specifying the CPU architecture to virtualization,
and <code>machine</code> referring to the machine
--
git-series 0.9.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-listOn 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: > Use preferred name: 'xen'. I'd be fine with this change if the actual code used the preferred name too :-). E.g. config containing <type arch='x86_64' machine='xenpv'>xen</type> will be shown as <type arch='x86_64' machine='xenpv'>linux</type> after virsh define; virsh dumpxml. Also, virsh domxml-from-native will produce the linux variant. Regards, Jim > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> > --- > docs/formatdomain.html.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index 19b7312..8043c7c 100644 > --- a/docs/formatdomain.html.in > +++ b/docs/formatdomain.html.in > @@ -144,8 +144,8 @@ > <dd>The content of the <code>type</code> element specifies the > type of operating system to be booted in the virtual machine. > <code>hvm</code> indicates that the OS is one designed to run > - on bare metal, so requires full virtualization. <code>linux</code> > - (badly named!) refers to an OS that supports the Xen 3 hypervisor > + on bare metal, so requires full virtualization. <code>xen</code> > + refers to an OS that supports the Xen 3 hypervisor > guest ABI. There are also two optional attributes, <code>arch</code> > specifying the CPU architecture to virtualization, > and <code>machine</code> referring to the machine > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote: > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: > > Use preferred name: 'xen'. > > I'd be fine with this change if the actual code used the preferred name too > :-). E.g. config containing > > <type arch='x86_64' machine='xenpv'>xen</type> > > will be shown as > > <type arch='x86_64' machine='xenpv'>linux</type> > > after virsh define; virsh dumpxml. Also, virsh domxml-from-native will > produce the linux variant. I was thinking about this and decided to left it intact for backward compatibility - so config from `virsh dumpxml` will work with very old libvirt version. But if that would be acceptable, I'd very much like to change that too. What are opinions about that? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote: > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: > > > Use preferred name: 'xen'. > > > > I'd be fine with this change if the actual code used the preferred name too > > :-). E.g. config containing > > > > <type arch='x86_64' machine='xenpv'>xen</type> > > > > will be shown as > > > > <type arch='x86_64' machine='xenpv'>linux</type> > > > > after virsh define; virsh dumpxml. Also, virsh domxml-from-native will > > produce the linux variant. > > I was thinking about this and decided to left it intact for backward > compatibility - so config from `virsh dumpxml` will work with very old > libvirt version. But if that would be acceptable, I'd very much like to > change that too. What are opinions about that? We can't change what we are reporting in the XML here, no matter how stupid our original choice of terminology was. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote: > > On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote: > > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: > > > > Use preferred name: 'xen'. > > > > > > I'd be fine with this change if the actual code used the preferred name too > > > :-). E.g. config containing > > > > > > <type arch='x86_64' machine='xenpv'>xen</type> > > > > > > will be shown as > > > > > > <type arch='x86_64' machine='xenpv'>linux</type> > > > > > > after virsh define; virsh dumpxml. Also, virsh domxml-from-native will > > > produce the linux variant. > > > > I was thinking about this and decided to left it intact for backward > > compatibility - so config from `virsh dumpxml` will work with very old > > libvirt version. But if that would be acceptable, I'd very much like to > > change that too. What are opinions about that? > > We can't change what we are reporting in the XML here, no matter how > stupid our original choice of terminology was. Ok. What about other patches (not really depending on this one)? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 08/31/2018 07:50 AM, Marek Marczykowski-Górecki wrote: > On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote: >> On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote: >>> On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote: >>>> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: >>>>> Use preferred name: 'xen'. >>>> >>>> I'd be fine with this change if the actual code used the preferred name too >>>> :-). E.g. config containing >>>> >>>> <type arch='x86_64' machine='xenpv'>xen</type> >>>> >>>> will be shown as >>>> >>>> <type arch='x86_64' machine='xenpv'>linux</type> >>>> >>>> after virsh define; virsh dumpxml. Also, virsh domxml-from-native will >>>> produce the linux variant. >>> >>> I was thinking about this and decided to left it intact for backward >>> compatibility - so config from `virsh dumpxml` will work with very old >>> libvirt version. But if that would be acceptable, I'd very much like to >>> change that too. What are opinions about that? >> >> We can't change what we are reporting in the XML here, no matter how >> stupid our original choice of terminology was. > > Ok. What about other patches (not really depending on this one)? Sorry for the delay reviewing the remaining patches, but I think you are accustomed to my delays :-). I hope to get to them in the next days. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
This is actually a source of great frustration as many vendors ship the machine type with custom strings. Engineers then do virsh dumpxml's from one sys and wonder why it doesn't work on another without realizing say ubuntu has this set to a machine type different to rhel ( but actually are basically just 'normal' pc type definitions). -Joel On 6 September 2018 at 10:40, Jim Fehlig <jfehlig@suse.com> wrote: > On 08/31/2018 07:50 AM, Marek Marczykowski-Górecki wrote: >> >> On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote: >>> >>> On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki >>> wrote: >>>> >>>> On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote: >>>>> >>>>> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote: >>>>>> >>>>>> Use preferred name: 'xen'. >>>>> >>>>> >>>>> I'd be fine with this change if the actual code used the preferred name >>>>> too >>>>> :-). E.g. config containing >>>>> >>>>> <type arch='x86_64' machine='xenpv'>xen</type> >>>>> >>>>> will be shown as >>>>> >>>>> <type arch='x86_64' machine='xenpv'>linux</type> >>>>> >>>>> after virsh define; virsh dumpxml. Also, virsh domxml-from-native will >>>>> produce the linux variant. >>>> >>>> >>>> I was thinking about this and decided to left it intact for backward >>>> compatibility - so config from `virsh dumpxml` will work with very old >>>> libvirt version. But if that would be acceptable, I'd very much like to >>>> change that too. What are opinions about that? >>> >>> >>> We can't change what we are reporting in the XML here, no matter how >>> stupid our original choice of terminology was. >> >> >> Ok. What about other patches (not really depending on this one)? > > > Sorry for the delay reviewing the remaining patches, but I think you are > accustomed to my delays :-). I hope to get to them in the next days. > > Regards, > Jim > > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2025 Red Hat, Inc.