1. Patchew
  2. Libvirt
  3. [libvirt] [PATCH 0/3] Add setting CPU features (CPUID) with libxenlight driver.
  4. View patch

[libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml

Marek Marczykowski-Górecki posted 3 patches 7 years, 10 months ago
There is a newer version of this series
[libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml
Posted by Marek Marczykowski-Górecki 7 years, 10 months ago 
CPUID leaf 7 is sub-leaf aware. Add missing attribute.
---
 src/cpu/cpu_map.xml | 58 +++++++++++++++++++++++-----------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index 29b5b59..037a057 100644
--- a/src/cpu/cpu_map.xml
+++ b/src/cpu/cpu_map.xml
@@ -195,93 +195,93 @@
 
     <!-- cpuid function 0x7 ecx 0x0 features -->
     <feature name='fsgsbase'>
-      <cpuid eax_in='0x07' ebx='0x00000001'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000001'/>
     </feature>
     <feature name='tsc_adjust'> <!-- tsc-adjust -->
-      <cpuid eax_in='0x07' ebx='0x00000002'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000002'/>
     </feature>
     <feature name='bmi1'>
-      <cpuid eax_in='0x07' ebx='0x00000008'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000008'/>
     </feature>
     <feature name='hle'>
-      <cpuid eax_in='0x07' ebx='0x00000010'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000010'/>
     </feature>
     <feature name='avx2'>
-      <cpuid eax_in='0x07' ebx='0x00000020'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000020'/>
     </feature>
     <feature name='smep'>
-      <cpuid eax_in='0x07' ebx='0x00000080'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000080'/>
     </feature>
     <feature name='bmi2'>
-      <cpuid eax_in='0x07' ebx='0x00000100'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000100'/>
     </feature>
     <feature name='erms'>
-      <cpuid eax_in='0x07' ebx='0x00000200'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000200'/>
     </feature>
     <feature name='invpcid'>
-      <cpuid eax_in='0x07' ebx='0x00000400'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000400'/>
     </feature>
     <feature name='rtm'>
-      <cpuid eax_in='0x07' ebx='0x00000800'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000800'/>
     </feature>
     <feature name='cmt'>
-      <cpuid eax_in='0x07' ebx='0x00001000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00001000'/>
     </feature>
     <feature name='mpx'>
-      <cpuid eax_in='0x07' ebx='0x00004000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00004000'/>
     </feature>
     <feature name='avx512f'>
-      <cpuid eax_in='0x07' ebx='0x00010000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00010000'/>
     </feature>
     <feature name='avx512dq'>
-      <cpuid eax_in='0x07' ebx='0x00020000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00020000'/>
     </feature>
     <feature name='rdseed'>
-      <cpuid eax_in='0x07' ebx='0x00040000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00040000'/>
     </feature>
     <feature name='adx'>
-      <cpuid eax_in='0x07' ebx='0x00080000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00080000'/>
     </feature>
     <feature name='smap'>
-      <cpuid eax_in='0x07' ebx='0x00100000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00100000'/>
     </feature>
     <feature name='avx512ifma'>
-      <cpuid eax_in='0x07' ebx='0x00200000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00200000'/>
     </feature>
     <feature name='clflushopt'>
-      <cpuid eax_in='0x07' ebx='0x00800000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00800000'/>
     </feature>
     <feature name='avx512pf'>
-      <cpuid eax_in='0x07' ebx='0x04000000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x04000000'/>
     </feature>
     <feature name='avx512er'>
-      <cpuid eax_in='0x07' ebx='0x08000000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x08000000'/>
     </feature>
     <feature name='avx512cd'>
-      <cpuid eax_in='0x07' ebx='0x10000000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x10000000'/>
     </feature>
     <feature name='avx512bw'>
-      <cpuid eax_in='0x07' ebx='0x40000000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x40000000'/>
     </feature>
     <feature name='avx512vl'>
-      <cpuid eax_in='0x07' ebx='0x80000000'/>
+      <cpuid eax_in='0x07' ecx_in='0' ebx='0x80000000'/>
     </feature>
 
     <feature name='avx512vbmi'>
-      <cpuid eax_in='0x07' ecx='0x00000002'/>
+      <cpuid eax_in='0x07' ecx_in='0' ecx='0x00000002'/>
     </feature>
     <feature name='pku'>
-      <cpuid eax_in='0x07' ecx='0x00000008'/>
+      <cpuid eax_in='0x07' ecx_in='0' ecx='0x00000008'/>
     </feature>
     <feature name='ospke'>
-      <cpuid eax_in='0x07' ecx='0x00000010'/>
+      <cpuid eax_in='0x07' ecx_in='0' ecx='0x00000010'/>
     </feature>
 
     <feature name='avx512-4vnniw'>
-      <cpuid eax_in='0x07' edx='0x00000004'/>
+      <cpuid eax_in='0x07' ecx_in='0' edx='0x00000004'/>
     </feature>
     <feature name='avx512-4fmaps'>
-      <cpuid eax_in='0x07' edx='0x00000008'/>
+      <cpuid eax_in='0x07' ecx_in='0' edx='0x00000008'/>
     </feature>
 
     <!-- Processor Extended State Enumeration sub leaf 1 -->
-- 
git-series 0.9.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml
Posted by Jiri Denemark 7 years, 10 months ago 
On Thu, Jun 29, 2017 at 03:11:41 +0200, Marek Marczykowski-Górecki wrote:
> CPUID leaf 7 is sub-leaf aware. Add missing attribute.
> ---
>  src/cpu/cpu_map.xml | 58 +++++++++++++++++++++++-----------------------
>  1 file changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
> index 29b5b59..037a057 100644
> --- a/src/cpu/cpu_map.xml
> +++ b/src/cpu/cpu_map.xml
> @@ -195,93 +195,93 @@
>  
>      <!-- cpuid function 0x7 ecx 0x0 features -->
>      <feature name='fsgsbase'>
> -      <cpuid eax_in='0x07' ebx='0x00000001'/>
> +      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000001'/>

Why? Zero is the default value for ecx_in, I don't see a strong reason
for mentioning it explicitly. If we do this, we should set the value to
0x00 though.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml
Posted by Marek Marczykowski-Górecki 7 years, 10 months ago 
On Thu, Jun 29, 2017 at 09:51:58AM +0200, Jiri Denemark wrote:
> On Thu, Jun 29, 2017 at 03:11:41 +0200, Marek Marczykowski-Górecki wrote:
> > CPUID leaf 7 is sub-leaf aware. Add missing attribute.
> > ---
> >  src/cpu/cpu_map.xml | 58 +++++++++++++++++++++++-----------------------
> >  1 file changed, 29 insertions(+), 29 deletions(-)
> > 
> > diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
> > index 29b5b59..037a057 100644
> > --- a/src/cpu/cpu_map.xml
> > +++ b/src/cpu/cpu_map.xml
> > @@ -195,93 +195,93 @@
> >  
> >      <!-- cpuid function 0x7 ecx 0x0 features -->
> >      <feature name='fsgsbase'>
> > -      <cpuid eax_in='0x07' ebx='0x00000001'/>
> > +      <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000001'/>
> 
> Why? Zero is the default value for ecx_in, I don't see a strong reason
> for mentioning it explicitly. If we do this, we should set the value to
> 0x00 though.

There is a difference (at CPUID instruction level) between ignoring ECX
value (leaf 1 for example) and requiring it to be set to 0. Looks like
virCPUx86CPUID structure does not support this distinction though.
Anyway I think it's better to include it there, will change to 0x00.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.