[libvirt] [PATCH] tests: qemuxml2argv: Drop some unused args files

Peter Krempa posted 1 patch 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/d93d7093043e41738dffc5a8a00fde848280d9ee.1535382189.git.pkrempa@redhat.com
Test syntax-check passed
tests/qemuxml2argvdata/aarch64-acpi-nouefi.args | 22 ---------------------
tests/qemuxml2argvdata/hostdev-scsi-boot.args   | 26 -------------------------
2 files changed, 48 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/aarch64-acpi-nouefi.args
delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-boot.args
[libvirt] [PATCH] tests: qemuxml2argv: Drop some unused args files
Posted by Peter Krempa 5 years, 8 months ago
aarch64-acpi-nouefi and hostdev-scsi-boot are unused. Noticed when
checking whether '-nodefconfig' is still used by libvirt.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuxml2argvdata/aarch64-acpi-nouefi.args | 22 ---------------------
 tests/qemuxml2argvdata/hostdev-scsi-boot.args   | 26 -------------------------
 2 files changed, 48 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/aarch64-acpi-nouefi.args
 delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-boot.args

diff --git a/tests/qemuxml2argvdata/aarch64-acpi-nouefi.args b/tests/qemuxml2argvdata/aarch64-acpi-nouefi.args
deleted file mode 100644
index 5d9e1fb7c8..0000000000
--- a/tests/qemuxml2argvdata/aarch64-acpi-nouefi.args
+++ /dev/null
@@ -1,22 +0,0 @@
-LC_ALL=C \
-PATH=/bin \
-HOME=/home/test \
-USER=test \
-LOGNAME=test \
-QEMU_AUDIO_DRV=none \
-/usr/bin/qemu-system-aarch64 \
--name guest \
--S \
--M virt \
--cpu host \
--m 1024 \
--smp 1,sockets=1,cores=1,threads=1 \
--uuid 496d7ea8-9739-544b-4ebd-ef08be936e8b \
--nographic \
--nodefconfig \
--nodefaults \
--monitor unix:/tmp/lib/domain--1-guest/monitor.sock,server,nowait \
--boot c \
--kernel /var/lib/libvirt/images/guest.vmlinux \
--initrd /var/lib/libvirt/images/guest.initramfs \
--append 'console=ttyAMA0 rw root=/dev/vda rootwait'
diff --git a/tests/qemuxml2argvdata/hostdev-scsi-boot.args b/tests/qemuxml2argvdata/hostdev-scsi-boot.args
deleted file mode 100644
index efbdc81415..0000000000
--- a/tests/qemuxml2argvdata/hostdev-scsi-boot.args
+++ /dev/null
@@ -1,26 +0,0 @@
-LC_ALL=C \
-PATH=/bin \
-HOME=/home/test \
-USER=test \
-LOGNAME=test \
-QEMU_AUDIO_DRV=none \
-/usr/bin/qemu-system-i686 \
--name QEMUGuest1 \
--S \
--M pc \
--m 214 \
--smp 1 \
--uuid c7a5fdbd-edaf-9466-926a-d65c16db1809 \
--nographic \
--nodefconfig \
--nodefaults \
--monitor unix:/tmp/test-monitor,server,nowait \
--no-acpi \
--device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x3 \
--usb \
--drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-ide0-0-0 \
--device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
--drive file=/dev/sg0,if=none,id=drive-hostdev0 \
--device scsi-generic,bus=scsi0.0,channel=0,scsi-id=4,lun=8,\
-drive=drive-hostdev0,id=hostdev0,bootindex=1 \
--device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x4
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: qemuxml2argv: Drop some unused args files
Posted by Ján Tomko 5 years, 8 months ago
On Mon, Aug 27, 2018 at 05:03:09PM +0200, Peter Krempa wrote:
>aarch64-acpi-nouefi and hostdev-scsi-boot are unused.

Unused since their introduction in commit deb38c4 and bab6ee6
respectively.

>Noticed when
>checking whether '-nodefconfig' is still used by libvirt.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tests/qemuxml2argvdata/aarch64-acpi-nouefi.args | 22 ---------------------
> tests/qemuxml2argvdata/hostdev-scsi-boot.args   | 26 -------------------------
> 2 files changed, 48 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/aarch64-acpi-nouefi.args
> delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-boot.args
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list