From nobody Wed May 14 07:02:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525688145762964.3876384669077; Mon, 7 May 2018 03:15:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D9713003A55; Mon, 7 May 2018 10:15:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0895C608F7; Mon, 7 May 2018 10:15:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 00B4C1808800; Mon, 7 May 2018 10:15:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w47A6gMe022954 for ; Mon, 7 May 2018 06:06:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 515BF111F3DB; Mon, 7 May 2018 10:06:42 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA2F6111F3DA for ; Mon, 7 May 2018 10:06:41 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 7 May 2018 12:06:31 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 4/9] connect: Pass error into virtDBusConnectOpen function X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 07 May 2018 10:15:44 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We need to pass the error pointer in order to report proper error. Signed-off-by: Pavel Hrdina --- src/connect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/connect.c b/src/connect.c index cd90939..fd335e3 100644 --- a/src/connect.c +++ b/src/connect.c @@ -342,7 +342,7 @@ virtDBusConnectDomainLookupByID(GVariant *inArgs, =20 g_variant_get(inArgs, "(u)", &id); =20 - if (!virtDBusConnectOpen(connect, NULL)) + if (!virtDBusConnectOpen(connect, error)) return; =20 domain =3D virDomainLookupByID(connect->connection, id); @@ -370,7 +370,7 @@ virtDBusConnectDomainLookupByName(GVariant *inArgs, =20 g_variant_get(inArgs, "(s)", &name); =20 - if (!virtDBusConnectOpen(connect, NULL)) + if (!virtDBusConnectOpen(connect, error)) return; =20 domain =3D virDomainLookupByName(connect->connection, name); @@ -398,7 +398,7 @@ virtDBusConnectDomainLookupByUUID(GVariant *inArgs, =20 g_variant_get(inArgs, "(s)", &uuidstr); =20 - if (!virtDBusConnectOpen(connect, NULL)) + if (!virtDBusConnectOpen(connect, error)) return; =20 domain =3D virDomainLookupByUUIDString(connect->connection, uuidstr); --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list