From nobody Wed May 14 13:54:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523953274920119.79236345589175; Tue, 17 Apr 2018 01:21:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42AE85F7B5; Tue, 17 Apr 2018 08:21:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F188B17115; Tue, 17 Apr 2018 08:21:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 64B844CAA2; Tue, 17 Apr 2018 08:21:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3H8L2kM020891 for ; Tue, 17 Apr 2018 04:21:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 89F6A2026DFD; Tue, 17 Apr 2018 08:21:02 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DC322026E04 for ; Tue, 17 Apr 2018 08:21:02 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 17 Apr 2018 10:20:52 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 4/5] virobject: Check if @parent is the first member in class X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 17 Apr 2018 08:21:13 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Our virObject code relies heavily on the fact that the first member of the class struct is type of virObject (or some derivation of if). Let's check for that. Signed-off-by: Michal Privoznik --- src/util/virobject.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virobject.h b/src/util/virobject.h index 128d3ba2d2..e174c17eb8 100644 --- a/src/util/virobject.h +++ b/src/util/virobject.h @@ -76,10 +76,12 @@ virClassPtr virClassForObjectRWLockable(void); # endif =20 # define VIR_CLASS_NEW(prnt, name) \ + verify(offsetof(name, parent) =3D=3D 0); \ if (!(name##Class =3D virClassNew(prnt, #name, sizeof(name), name##Dis= pose))) \ return -1; =20 # define VIR_CLASS_NEW_GOTO(prnt, name, label) \ + verify(offsetof(name, parent) =3D=3D 0); \ if (!(name##Class =3D virClassNew(prnt, #name, sizeof(name), name##Dis= pose))) \ goto label; =20 --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list