1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place

Martin Kletzander posted 1 patch 8 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/e7a4b373a4589c432a1640fb0247deb098a9df04.1494594687.git.mkletzan@redhat.com
tests/test-wrap-argv.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Martin Kletzander 8 years ago 
I like to use it that way and every time I try running it I just
instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 tests/test-wrap-argv.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
index f0d3c0ba2d10..7867e9d7194e 100755
--- a/tests/test-wrap-argv.pl
+++ b/tests/test-wrap-argv.pl
@@ -31,7 +31,7 @@
 $in_place = 0;
 $check = 0;

-if (@ARGV[0] eq "--in-place") {
+if (@ARGV[0] eq "--in-place" or @ARGV[0] eq "-i") {
     $in_place = 1;
     shift @ARGV;
 } elsif (@ARGV[0] eq "--check") {
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Pavel Hrdina 8 years ago 
On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
> I like to use it that way and every time I try running it I just
> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  tests/test-wrap-argv.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Martin Kletzander 8 years ago 
On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
>On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>> I like to use it that way and every time I try running it I just
>> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>>
>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> ---
>>  tests/test-wrap-argv.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

Does that mean ACK?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Pavel Hrdina 8 years ago 
On Fri, May 12, 2017 at 03:59:46PM +0200, Martin Kletzander wrote:
> On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
> >On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
> >> I like to use it that way and every time I try running it I just
> >> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
> >>
> >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> >> ---
> >>  tests/test-wrap-argv.pl | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
> 
> Does that mean ACK?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight

s/kernel/libvirt/ for the text

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Martin Kletzander 8 years ago 
On Fri, May 12, 2017 at 04:12:06PM +0200, Pavel Hrdina wrote:
>On Fri, May 12, 2017 at 03:59:46PM +0200, Martin Kletzander wrote:
>> On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
>> >On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>> >> I like to use it that way and every time I try running it I just
>> >> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>> >>
>> >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> >> ---
>> >>  tests/test-wrap-argv.pl | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
>>
>> Does that mean ACK?
>
>https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight
>
>s/kernel/libvirt/ for the text
>

Honestly, I didn't know there is also definition of other -by:'s, I
probably read those docs back when there was just Signed-of-by
definition.  So thanks for new info ;)  Anyway, do we have some
documentation about libvirt using these tags as well?  I only remember
talking about S-o-b being "preferred", not even required.  Any news on
that front?  BTW: I'll push this in a while.

>Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Pavel Hrdina 8 years ago 
On Fri, May 12, 2017 at 04:32:15PM +0200, Martin Kletzander wrote:
> On Fri, May 12, 2017 at 04:12:06PM +0200, Pavel Hrdina wrote:
> >On Fri, May 12, 2017 at 03:59:46PM +0200, Martin Kletzander wrote:
> >> On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
> >> >On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
> >> >> I like to use it that way and every time I try running it I just
> >> >> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
> >> >>
> >> >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> >> >> ---
> >> >>  tests/test-wrap-argv.pl | 2 +-
> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> >Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
> >>
> >> Does that mean ACK?
> >
> >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight
> >
> >s/kernel/libvirt/ for the text
> >
> 
> Honestly, I didn't know there is also definition of other -by:'s, I
> probably read those docs back when there was just Signed-of-by
> definition.  So thanks for new info ;)  Anyway, do we have some
> documentation about libvirt using these tags as well?  I only remember
> talking about S-o-b being "preferred", not even required.  Any news on
> that front?  BTW: I'll push this in a while.

No there is no documentation yet and nothing is required.  I just like
the idea of using Signed-of-by, Reviewed-by, Tested-by and Reported-by
tags :) .

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Ján Tomko 8 years ago 
On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>I like to use it that way and every time I try running it I just
>instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>
>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>---
> tests/test-wrap-argv.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
>index f0d3c0ba2d10..7867e9d7194e 100755
>--- a/tests/test-wrap-argv.pl
>+++ b/tests/test-wrap-argv.pl
>@@ -31,7 +31,7 @@
> $in_place = 0;
> $check = 0;
>
>-if (@ARGV[0] eq "--in-place") {
>+if (@ARGV[0] eq "--in-place" or @ARGV[0] eq "-i") {
>     $in_place = 1;
>     shift @ARGV;
> } elsif (@ARGV[0] eq "--check") {

or @ARGV[0] eq "-c" maybe?

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Martin Kletzander 8 years ago 
On Fri, May 12, 2017 at 03:23:27PM +0200, Ján Tomko wrote:
>On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>>I like to use it that way and every time I try running it I just
>>instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>>
>>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>>---
>> tests/test-wrap-argv.pl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
>>index f0d3c0ba2d10..7867e9d7194e 100755
>>--- a/tests/test-wrap-argv.pl
>>+++ b/tests/test-wrap-argv.pl
>>@@ -31,7 +31,7 @@
>> $in_place = 0;
>> $check = 0;
>>
>>-if (@ARGV[0] eq "--in-place") {
>>+if (@ARGV[0] eq "--in-place" or @ARGV[0] eq "-i") {
>>     $in_place = 1;
>>     shift @ARGV;
>> } elsif (@ARGV[0] eq "--check") {
>
>or @ARGV[0] eq "-c" maybe?
>

Does that mean ACK with that added as well?

>Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place
Posted by Ján Tomko 8 years ago 
On Fri, May 12, 2017 at 04:00:06PM +0200, Martin Kletzander wrote:
>On Fri, May 12, 2017 at 03:23:27PM +0200, Ján Tomko wrote:
>>On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>>>I like to use it that way and every time I try running it I just
>>>instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>>>
>>>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>>>---
>>> tests/test-wrap-argv.pl | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
>>>index f0d3c0ba2d10..7867e9d7194e 100755
>>>--- a/tests/test-wrap-argv.pl
>>>+++ b/tests/test-wrap-argv.pl
>>>@@ -31,7 +31,7 @@
>>> $in_place = 0;
>>> $check = 0;
>>>
>>>-if (@ARGV[0] eq "--in-place") {
>>>+if (@ARGV[0] eq "--in-place" or @ARGV[0] eq "-i") {
>>>     $in_place = 1;
>>>     shift @ARGV;
>>> } elsif (@ARGV[0] eq "--check") {
>>
>>or @ARGV[0] eq "-c" maybe?
>>
>
>Does that mean ACK with that added as well?

Hopefully P.H.'s R-b served as an ACK.

It was just a thought I had and liked so much I had to share it with the
world.

Feel free to include it in the commit or disregard it completely.

Have a nice weekend.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.