From nobody Tue Dec 16 08:53:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519396088459730.4810855060279; Fri, 23 Feb 2018 06:28:08 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14833C0AD1F0; Fri, 23 Feb 2018 14:28:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1B3B6018D; Fri, 23 Feb 2018 14:28:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 87A934A475; Fri, 23 Feb 2018 14:28:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1NERod7032720 for ; Fri, 23 Feb 2018 09:27:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 25B7C9C04C; Fri, 23 Feb 2018 14:27:50 +0000 (UTC) Received: from dnr.brq.redhat.com (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0E17AF021 for ; Fri, 23 Feb 2018 14:27:49 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 23 Feb 2018 15:27:33 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/16] vboxDumpNetworks: reduce indentation level X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 23 Feb 2018 14:28:07 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The 'enabled' bool is initialized to false, there is no need to nest the conditions. Signed-off-by: J=C3=A1n Tomko --- src/vbox/vbox_common.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 295f48376..1d38001f9 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -3822,20 +3822,19 @@ vboxDumpNetworks(virDomainDefPtr def, vboxDriverPtr= data, IMachine *machine, PRU for (i =3D 0; netAdpIncCnt < def->nnets && i < networkAdapterCount; i+= +) { INetworkAdapter *adapter =3D NULL; virDomainNetDefPtr net =3D def->nets[netAdpIncCnt]; + PRBool enabled =3D PR_FALSE; =20 gVBoxAPI.UIMachine.GetNetworkAdapter(machine, i, &adapter); - if (adapter) { - PRBool enabled =3D PR_FALSE; - + if (adapter) gVBoxAPI.UINetworkAdapter.GetEnabled(adapter, &enabled); - if (enabled) { - vboxDumpNetwork(net, data, adapter); =20 - netAdpIncCnt++; - } + if (enabled) { + vboxDumpNetwork(net, data, adapter); =20 - VBOX_RELEASE(adapter); + netAdpIncCnt++; } + + VBOX_RELEASE(adapter); } } =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list