From nobody Tue May 13 09:25:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1539259445784788.3523374588318; Thu, 11 Oct 2018 05:04:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FDBA3082A30; Thu, 11 Oct 2018 12:04:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AE9F6BF98; Thu, 11 Oct 2018 12:04:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D9F363D61; Thu, 11 Oct 2018 12:04:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w9BC41sc022996 for ; Thu, 11 Oct 2018 08:04:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id 37B5C91291; Thu, 11 Oct 2018 12:04:01 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id B23CA600C9 for ; Thu, 11 Oct 2018 12:04:00 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 11 Oct 2018 14:03:41 +0200 Message-Id: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 01/11] security: Always spawn process for transactions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 11 Oct 2018 12:04:04 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In the next commit the virSecurityManagerMetadataLock() is going to be turned thread unsafe. Therefore, we have to spawn a separate process for it. Always. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 12 ++++++------ src/security/security_selinux.c | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index da4a6c72fe..21db3b9684 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -562,12 +562,12 @@ virSecurityDACTransactionCommit(virSecurityManagerPtr= mgr ATTRIBUTE_UNUSED, goto cleanup; } =20 - if ((pid =3D=3D -1 && - virSecurityDACTransactionRun(pid, list) < 0) || - (pid !=3D -1 && - virProcessRunInMountNamespace(pid, - virSecurityDACTransactionRun, - list) < 0)) + if (pid =3D=3D -1) + pid =3D getpid(); + + if (virProcessRunInMountNamespace(pid, + virSecurityDACTransactionRun, + list) < 0) goto cleanup; =20 ret =3D 0; diff --git a/src/security/security_selinux.c b/src/security/security_selinu= x.c index 467d1e6bfe..3c847d8dcb 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -1103,12 +1103,12 @@ virSecuritySELinuxTransactionCommit(virSecurityMana= gerPtr mgr ATTRIBUTE_UNUSED, goto cleanup; } =20 - if ((pid =3D=3D -1 && - virSecuritySELinuxTransactionRun(pid, list) < 0) || - (pid !=3D -1 && - virProcessRunInMountNamespace(pid, - virSecuritySELinuxTransactionRun, - list) < 0)) + if (pid =3D=3D -1) + pid =3D getpid(); + + if (virProcessRunInMountNamespace(pid, + virSecuritySELinuxTransactionRun, + list) < 0) goto cleanup; =20 ret =3D 0; --=20 2.18.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list