main: add support for all usable libvirt drivers

[libvirt] [dbus PATCH v2] main: add support for all usable libvirt drivers

Posted by Pavel Hrdina 7 years, 3 months ago

Some of the drivers are remote only, such as ESX, GSX, VPX, PHyp and
HyperV.  Currently we support only local drivers.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/main.c          | 21 +++++++++++++++++----
 test/libvirttest.py |  2 +-
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/main.c b/src/main.c
index ab03bc1..32c1cc4 100644
--- a/src/main.c
+++ b/src/main.c
@@ -85,13 +85,26 @@ struct virtDBusDriver {
 };
 
 static const struct virtDBusDriver sessionDrivers[] = {
-    { "qemu:///session",    "/org/libvirt/qemu" },
-    { "test:///default",    "/org/libvirt/test" },
+    { "qemu:///session",            "/org/libvirt/QEMU" },
+    { "test:///default",            "/org/libvirt/Test" },
+    { "uml:///session",             "/org/libvirt/UML" },
+    { "vbox:///session",            "/org/libvirt/VBox" },
+    { "vmwarefusion:///session",    "/org/libvirt/VMwareFusion" },
+    { "vmwareplayer:///session",    "/org/libvirt/VMwarePlayer" },
+    { "vmwarews:///session",        "/org/libvirt/VMwareWS" },
 };
 
 static const struct virtDBusDriver systemDrivers[] = {
-    { "qemu:///system",     "/org/libvirt/qemu" },
-    { "test:///default",    "/org/libvirt/test" },
+    { "XenApi://localhost/",    "/org/libvirt/XenAPI" },
+    { "bhyve:///system",        "/org/libvirt/BHyve" },
+    { "lxc:///",                "/org/libvirt/LXC" },
+    { "openvz:///system",       "/org/libvirt/OpenVZ" },
+    { "qemu:///system",         "/org/libvirt/QEMU" },
+    { "test:///default",        "/org/libvirt/Test" },
+    { "uml:///system",          "/org/libvirt/UML" },
+    { "vbox:///system",         "/org/libvirt/VBox" },
+    { "vz:///system",           "/org/libvirt/VZ" },
+    { "xen:///",                "/org/libvirt/Xen" },
 };
 
 int
diff --git a/test/libvirttest.py b/test/libvirttest.py
index 579485f..6a00aea 100644
--- a/test/libvirttest.py
+++ b/test/libvirttest.py
@@ -38,7 +38,7 @@ class TestCase(unittest.TestCase):
         else:
             raise TimeoutError('error starting libvirt-dbus')
 
-        obj = self.bus.get_object('org.libvirt', '/org/libvirt/test')
+        obj = self.bus.get_object('org.libvirt', '/org/libvirt/Test')
         self.connect = dbus.Interface(obj, 'org.libvirt.Connect')
 
     def tearDown(self):
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH v2] main: add support for all usable libvirt drivers

Posted by Daniel P. Berrange 7 years, 3 months ago

On Tue, Jan 23, 2018 at 02:11:50PM +0100, Pavel Hrdina wrote:
> Some of the drivers are remote only, such as ESX, GSX, VPX, PHyp and
> HyperV.  Currently we support only local drivers.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/main.c          | 21 +++++++++++++++++----
>  test/libvirttest.py |  2 +-
>  2 files changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/src/main.c b/src/main.c
> index ab03bc1..32c1cc4 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -85,13 +85,26 @@ struct virtDBusDriver {
>  };
>  
>  static const struct virtDBusDriver sessionDrivers[] = {
> -    { "qemu:///session",    "/org/libvirt/qemu" },
> -    { "test:///default",    "/org/libvirt/test" },
> +    { "qemu:///session",            "/org/libvirt/QEMU" },
> +    { "test:///default",            "/org/libvirt/Test" },
> +    { "uml:///session",             "/org/libvirt/UML" },
> +    { "vbox:///session",            "/org/libvirt/VBox" },
> +    { "vmwarefusion:///session",    "/org/libvirt/VMwareFusion" },
> +    { "vmwareplayer:///session",    "/org/libvirt/VMwarePlayer" },
> +    { "vmwarews:///session",        "/org/libvirt/VMwareWS" },
>  };
>  
>  static const struct virtDBusDriver systemDrivers[] = {
> -    { "qemu:///system",     "/org/libvirt/qemu" },
> -    { "test:///default",    "/org/libvirt/test" },
> +    { "XenApi://localhost/",    "/org/libvirt/XenAPI" },

Now that I think some more, I have a feeling XenAPI servers are
a blackbox, so would be impossible to use localhost for that
too. We can always add it back later if I turn out to be wrong.

> +    { "bhyve:///system",        "/org/libvirt/BHyve" },
> +    { "lxc:///",                "/org/libvirt/LXC" },
> +    { "openvz:///system",       "/org/libvirt/OpenVZ" },
> +    { "qemu:///system",         "/org/libvirt/QEMU" },
> +    { "test:///default",        "/org/libvirt/Test" },
> +    { "uml:///system",          "/org/libvirt/UML" },
> +    { "vbox:///system",         "/org/libvirt/VBox" },
> +    { "vz:///system",           "/org/libvirt/VZ" },
> +    { "xen:///",                "/org/libvirt/Xen" },
>  };

If you remove XenAPI

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list