From nobody Sat May 4 23:22:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1538054099130153.99278772472462; Thu, 27 Sep 2018 06:14:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B39BC8666A; Thu, 27 Sep 2018 13:14:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB7386250E; Thu, 27 Sep 2018 13:14:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 62425181A12F; Thu, 27 Sep 2018 13:14:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w8RDEq3o030318 for ; Thu, 27 Sep 2018 09:14:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 653911042558; Thu, 27 Sep 2018 13:14:52 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD1F8103BAB2 for ; Thu, 27 Sep 2018 13:14:51 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 27 Sep 2018 15:14:49 +0200 Message-Id: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH for 4.8.0] qemu: Temporarily disable metadata locking X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 27 Sep 2018 13:14:57 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Turns out, there are couple of bugs that prevent this feature from being operational. Given how close to the release we are disable the feature temporarily. Hopefully, it can be enabled back after all the bugs are fixed. Signed-off-by: Michal Privoznik Reviewed-by: Jiri Denemark --- There are two major problems: 1) when using regular locking the lockspace code gets confused and starting domain is denied after hitting 60 second timeout. 2) the virtlockd connection FD might leak into children process resulting in sudden killing of libvirtd. I posted a patch for 2), and I'm working on patch for 1). src/qemu/libvirtd_qemu.aug | 1 - src/qemu/qemu.conf | 9 --------- src/qemu/qemu_conf.c | 11 ----------- src/qemu/test_libvirtd_qemu.aug.in | 1 - 4 files changed, 22 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 42e325d4fb..ddc4bbfd1d 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -98,7 +98,6 @@ module Libvirtd_qemu =3D | bool_entry "relaxed_acs_check" | bool_entry "allow_disk_format_probing" | str_entry "lock_manager" - | str_entry "metadata_lock_manager" =20 let rpc_entry =3D int_entry "max_queued" | int_entry "keepalive_interval" diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 84492719c4..8391332cb4 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -659,15 +659,6 @@ #lock_manager =3D "lockd" =20 =20 -# To serialize two or more daemons trying to change metadata on a -# file (e.g. a file on NFS share), libvirt offers a locking -# mechanism. Currently, only "lockd" is supported (or no locking -# at all if unset). Note that this is independent of lock_manager -# described above. -# -#metadata_lock_manager =3D "lockd" - - # Set limit of maximum APIs queued on one domain. All other APIs # over this threshold will fail on acquiring job lock. Specially, # setting to zero turns this feature off. diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 33508174cb..fc84186a7e 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -838,17 +838,6 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr= cfg, if (virConfGetValueString(conf, "lock_manager", &cfg->lockManagerName)= < 0) goto cleanup; =20 - if (virConfGetValueString(conf, "metadata_lock_manager", - &cfg->metadataLockManagerName) < 0) - goto cleanup; - if (cfg->metadataLockManagerName && - STRNEQ(cfg->metadataLockManagerName, "lockd")) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown metadata lock manager name %s"), - cfg->metadataLockManagerName); - goto cleanup; - } - if (virConfGetValueString(conf, "stdio_handler", &stdioHandler) < 0) goto cleanup; if (stdioHandler) { diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qe= mu.aug.in index 451e73126e..f1e8806ad2 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -81,7 +81,6 @@ module Test_libvirtd_qemu =3D { "mac_filter" =3D "1" } { "relaxed_acs_check" =3D "1" } { "lock_manager" =3D "lockd" } -{ "metadata_lock_manager" =3D "lockd" } { "max_queued" =3D "0" } { "keepalive_interval" =3D "5" } { "keepalive_count" =3D "5" } --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list