[patchew-devel] [PATCH] jsdifflib: font cleanup

Paolo Bonzini posted 1 patch 6 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/patchew-ci tags/patchew/20180228163858.9847-1-pbonzini@redhat.com
static/jsdifflib/diffview.css | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[patchew-devel] [PATCH] jsdifflib: font cleanup
Posted by Paolo Bonzini 6 years, 1 month ago
Having "Courier" in the font list somehow activates ligatures, which is
a bad idea for a monospaced font.  For the headings, Bitstream Vera Sans
(and the extended version DejaVu Sans) is much more similar to Verdana
than Arial and Helvetica.  Leave sans-serif as a final fallback, which
will probably be one of Arial/Helvetica/Liberation Sans, but prefer
the clearer Verdana-like fonts.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 static/jsdifflib/diffview.css | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/static/jsdifflib/diffview.css b/static/jsdifflib/diffview.css
index 811a593..94aadf6 100644
--- a/static/jsdifflib/diffview.css
+++ b/static/jsdifflib/diffview.css
@@ -33,10 +33,10 @@ table.diff {
 	white-space:pre-wrap
 }
 table.diff tbody { 
-	font-family:Courier, monospace
+	font-family:monospace;
 }
 table.diff tbody th {
-	font-family:verdana,arial,'Bitstream Vera Sans',helvetica,sans-serif;
+	font-family:Verdana,'DejaVu Sans','Bitstream Vera Sans',sans-serif;
 	background:#EED;
 	font-size:11px;
 	font-weight:normal;
@@ -49,7 +49,7 @@ table.diff tbody th {
 table.diff thead {
 	border-bottom:1px solid #BBC;
 	background:#EFEFEF;
-	font-family:Verdana
+	font-family:Verdana,'DejaVu Sans','Bitstream Vera Sans',sans-serif;
 }
 table.diff thead th.texttitle {
 	text-align:left
-- 
2.14.3


[patchew-devel] Re: [PATCH] jsdifflib: font cleanup
Posted by Fam Zheng 6 years, 1 month ago
On Wed, 02/28 17:38, Paolo Bonzini wrote:
> Having "Courier" in the font list somehow activates ligatures, which is
> a bad idea for a monospaced font.  For the headings, Bitstream Vera Sans
> (and the extended version DejaVu Sans) is much more similar to Verdana
> than Arial and Helvetica.  Leave sans-serif as a final fallback, which
> will probably be one of Arial/Helvetica/Liberation Sans, but prefer
> the clearer Verdana-like fonts.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  static/jsdifflib/diffview.css | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Fam