From nobody Fri Apr 19 21:03:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=patchew-devel-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=patchew-devel-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1521794123691317.6837019302884; Fri, 23 Mar 2018 01:35:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE89B5D697; Fri, 23 Mar 2018 08:35:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9A786611A6; Fri, 23 Mar 2018 08:35:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 407854CA99; Fri, 23 Mar 2018 08:35:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2N8ZHY0009546 for ; Fri, 23 Mar 2018 04:35:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id CB3D410B2B21; Fri, 23 Mar 2018 08:35:17 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-117-73.ams2.redhat.com [10.36.117.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03F3C10B2B3E for ; Fri, 23 Mar 2018 08:35:13 +0000 (UTC) From: Paolo Bonzini To: patchew-devel@redhat.com Date: Fri, 23 Mar 2018 09:35:11 +0100 Message-Id: <20180323083511.27880-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: patchew-devel@redhat.com Subject: [Patchew-devel] [PATCH] testing: remove dead code X-BeenThere: patchew-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Patchew development and discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: patchew-devel-bounces@redhat.com Errors-To: patchew-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 23 Mar 2018 08:35:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixes issue #72. --- mods/testing.py | 12 ------------ tests/test_testing.py | 2 -- 2 files changed, 14 deletions(-) diff --git a/mods/testing.py b/mods/testing.py index d6492aa..b05d9c9 100644 --- a/mods/testing.py +++ b/mods/testing.py @@ -59,10 +59,6 @@ class TestingModule(PatchewModule): BooleanSchema("enabled", "Enabled", desc=3D"Whether this test is enabled= ", default=3DTrue), - StringSchema("users", "Users", - desc=3D"List of allowed users to run = this test"), - StringSchema("testers", "Testers", - desc=3D"List of allowed testers to ru= n this test"), StringSchema("requirements", "Requirements", desc=3D"List of requirements of the t= est"), IntegerSchema("timeout", "Timeout", @@ -273,10 +269,6 @@ class TestingModule(PatchewModule): }) return ret =20 - def _build_message_prop_url(message, prop): - return reverse("testing-get-prop", - kwargs=3D{"project_or_series": obj.message_id}) - def rest_results_hook(self, request, message, results): for pn, p in message.get_properties().items(): if not pn.startswith("testing.report."): @@ -414,10 +406,6 @@ class TestingGetView(APILoginRequiredView): if obj.get_property("testing.report." + tn): done_tests.add(tn) continue - if t.get("tester") and tester !=3D t["tester"]: - continue - if t.get("user") and user.username !=3D t["user"]: - continue # TODO: group? ok =3D True reqs =3D t.get("requirements", "") diff --git a/tests/test_testing.py b/tests/test_testing.py index 0897bbc..8a22e1f 100755 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -21,8 +21,6 @@ def create_test(project, name): project.set_property(prefix + "enabled", True) project.set_property(prefix + "script", "#!/bin/bash\ntrue") project.set_property(prefix + "requirements", "") - project.set_property(prefix + "users", "") - project.set_property(prefix + "tester", "") =20 class TestingTest(PatchewTestCase): =20 --=20 2.16.2 _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel