From nobody Mon Dec 15 03:10:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=patchew-devel-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=patchew-devel-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526972320825159.07580025648588; Mon, 21 May 2018 23:58:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D97FB3673DC; Tue, 22 May 2018 06:58:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6B855D756; Tue, 22 May 2018 06:58:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B73214BB78; Tue, 22 May 2018 06:58:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4M6vxqu028150 for ; Tue, 22 May 2018 02:57:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 70E1430BF204; Tue, 22 May 2018 06:57:59 +0000 (UTC) Received: from mx1.redhat.com (ext-mx18.extmail.prod.ext.phx2.redhat.com [10.5.110.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AD9930BF209 for ; Tue, 22 May 2018 06:57:57 +0000 (UTC) Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A8F1D30C232F for ; Tue, 22 May 2018 06:57:46 +0000 (UTC) Received: by mail-pf0-f181.google.com with SMTP id w129-v6so8290338pfd.3 for ; Mon, 21 May 2018 23:57:46 -0700 (PDT) Received: from localhost.localdomain ([208.181.63.202]) by smtp.gmail.com with ESMTPSA id y2-v6sm19818676pgp.92.2018.05.21.23.57.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 23:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=J7skVuSI1x97kfc1Ebzu27OhLpc4HVpPi084QZ7t98w=; b=OPKwfPGdJp+K5ea15GeyRRuGep16wUu0+ov1J08Cz4DkD9WrKfqKsAgKBxIc8TMTyd c/DWVdKQp7YmD2sMVdKyCD2BK8CyWgrg1Chw9Gi1MyiQz47c9mwK0ytvZvgcr6DTxt6P 5+1B4QMJVTq6jpkRKEdhES9xxvrW1SuckF5cxY1Z1kZr197l90fvtCBqURumKJuc3Qtd jgPCPrD/u/R8g9w4Wh+FlAWlnoMR39Z7K8Ih0S6dwA6SyvJjKoZbqwBDS1v242djQsS6 3jYzJnroK6KQkufTee6haigp6Z1Bos/3RbqnpBCXFNiGcpV5pjaSdA9E2SJCnHCr/LSI 8h6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=J7skVuSI1x97kfc1Ebzu27OhLpc4HVpPi084QZ7t98w=; b=E6tONSwp0M2oznjstGOFledITMdEmoF+UB2u+uzbOhk+2cILAdn5zDzxMOKBPG7Zpx pKwfkLdY/3kUQgnyC/hALZPT2mKSR5i9e5Rc/lPp8qojHLKGpCi0gHRjbX/nCrk0T8Mu OJPEEH7nXBKSc6j7MwXt6bJLpOvZuxdI/JaU2gmQM37KEXztYyOSCSdrlbBYT2F4LfoP 6pahf3Hj+sFGFv8l1QpZ0ssPdVoQDAuNu6pM9Yh2yZFhXreoH5Bd4CZta++lfBUXUNAV Q5BUGF2jQ+M7uo+zAn7biFiz/ouLU2UguhsX0FEJ25cbUFPvhAM+yUG3W+IjXiOhzIsQ whxA== X-Gm-Message-State: ALKqPwdBJy7kbDMNWAkwpw/qU4KFzO6O4CST1bJWfReUJK4NIRhh5B4E L/i1+qbqw70FrZ8x76fmP2MLOWcE X-Google-Smtp-Source: AB8JxZrXgwWSlzNU6FfeEvoZoxlMX5fajfDsAMD3DxHegK8kNye7+oXyEy+RqblJNVbGOB8EbfFW0A== X-Received: by 2002:a62:c81d:: with SMTP id z29-v6mr22966231pff.81.1526972265789; Mon, 21 May 2018 23:57:45 -0700 (PDT) From: Paolo Bonzini To: patchew-devel@redhat.com Date: Tue, 22 May 2018 08:57:29 +0200 Message-Id: <20180522065740.9710-2-pbonzini@redhat.com> In-Reply-To: <20180522065740.9710-1-pbonzini@redhat.com> References: <20180522065740.9710-1-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 22 May 2018 06:57:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 22 May 2018 06:57:46 +0000 (UTC) for IP:'209.85.192.181' DOMAIN:'mail-pf0-f181.google.com' HELO:'mail-pf0-f181.google.com' FROM:'paolo.bonzini@gmail.com' RCPT:'' X-RedHat-Spam-Score: -1.2 (DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.192.181 mail-pf0-f181.google.com 209.85.192.181 mail-pf0-f181.google.com X-RedHat-Possible-Forgery: Paolo Bonzini X-Scanned-By: MIMEDefang 2.84 on 10.5.110.47 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-loop: patchew-devel@redhat.com Subject: [Patchew-devel] [PATCH 01/12] testing: remove dead code X-BeenThere: patchew-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Patchew development and discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: patchew-devel-bounces@redhat.com Errors-To: patchew-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 22 May 2018 06:58:39 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixes issue #72. --- mods/testing.py | 12 ------------ tests/test_testing.py | 2 -- 2 files changed, 14 deletions(-) diff --git a/mods/testing.py b/mods/testing.py index 24841f1..cafe9a2 100644 --- a/mods/testing.py +++ b/mods/testing.py @@ -59,10 +59,6 @@ class TestingModule(PatchewModule): BooleanSchema("enabled", "Enabled", desc=3D"Whether this test is enabled= ", default=3DTrue), - StringSchema("users", "Users", - desc=3D"List of allowed users to run = this test"), - StringSchema("testers", "Testers", - desc=3D"List of allowed testers to ru= n this test"), StringSchema("requirements", "Requirements", desc=3D"List of requirements of the t= est"), IntegerSchema("timeout", "Timeout", @@ -256,10 +252,6 @@ class TestingModule(PatchewModule): }) return ret =20 - def _build_message_prop_url(message, prop): - return reverse("testing-get-prop", - kwargs=3D{"project_or_series": obj.message_id}) - def rest_results_hook(self, request, obj, results, detailed=3DFalse): for pn, p in obj.get_properties().items(): if not pn.startswith("testing.report."): @@ -410,10 +402,6 @@ class TestingGetView(APILoginRequiredView): if obj.get_property("testing.report." + tn): done_tests.add(tn) continue - if t.get("tester") and tester !=3D t["tester"]: - continue - if t.get("user") and user.username !=3D t["user"]: - continue # TODO: group? ok =3D True reqs =3D t.get("requirements", "") diff --git a/tests/test_testing.py b/tests/test_testing.py index 3dcb505..73d13f1 100755 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -22,8 +22,6 @@ def create_test(project, name): project.set_property(prefix + "enabled", True) project.set_property(prefix + "script", "#!/bin/bash\ntrue") project.set_property(prefix + "requirements", "") - project.set_property(prefix + "users", "") - project.set_property(prefix + "tester", "") =20 class TestingTestCase(PatchewTestCase, metaclass=3Dabc.ABCMeta): =20 --=20 2.17.0 _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel