[Qemu-devel] [PATCH 0/3] slirp: fix 3 easy coverity warnings

Peter Maydell posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1486249715-5513-1-git-send-email-peter.maydell@linaro.org
Test checkpatch passed
Test docker passed
Test s390x failed
slirp/mbuf.c   | 30 ++++++++++++++----------------
slirp/socket.c |  4 +++-
slirp/udp.c    |  4 ++++
3 files changed, 21 insertions(+), 17 deletions(-)
[Qemu-devel] [PATCH 0/3] slirp: fix 3 easy coverity warnings
Posted by Peter Maydell 7 years, 1 month ago
This patchset fixes three easy-to-fix coverity warnings in the slirp
code (there are another 5 or so which are not quite so simple).

As usual, the preexisting tab-indent style for a lot of the slirp
code is well out of line with the QEMU/checkpatch preferences.
I opted to generally use QEMU style for the new lines but this
does look a bit of a mess in some ways; happy to adjust per
slirp maintainer preferences.

thanks
-- PMM

Peter Maydell (3):
  slirp: Check qemu_socket() return value in udp_listen()
  slirp: Convert mbufs to use g_malloc() and g_free()
  slirp: tcp_listen(): Don't try to close() an fd we never opened

 slirp/mbuf.c   | 30 ++++++++++++++----------------
 slirp/socket.c |  4 +++-
 slirp/udp.c    |  4 ++++
 3 files changed, 21 insertions(+), 17 deletions(-)

-- 
2.1.4