[v1] Record/replay refactoring and stuff

[PATCH 1/9] replay: fix event queue flush for qemu shutdown

Posted by Pavel Dovgalyuk 3 years, 2 months ago

This patch fixes event queue flush in the case of emulator
shutdown. replay_finish_events should be called when replay_mode
is not cleared.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
 replay/replay.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/replay/replay.c b/replay/replay.c
index 6df2abc18c..2d3607998a 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -387,9 +387,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
-    replay_mode = REPLAY_MODE_NONE;
-
     replay_finish_events();
+    replay_mode = REPLAY_MODE_NONE;
 }
 
 void replay_add_blocker(Error *reason)

Re: [PATCH 1/9] replay: fix event queue flush for qemu shutdown

Posted by Richard Henderson 3 years, 2 months ago

On 4/22/22 04:53, Pavel Dovgalyuk wrote:
> This patch fixes event queue flush in the case of emulator
> shutdown. replay_finish_events should be called when replay_mode
> is not cleared.
> 
> Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru>
> ---
>   replay/replay.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~