From nobody Thu Jul 17 02:22:39 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=ispras.ru ARC-Seal: i=1; a=rsa-sha256; t=1674544417; cv=none; d=zohomail.com; s=zohoarc; b=D8Q5M1WBh8GsTVgRHlDDV3GuVY0f6u+ZNptUePoEG4/3kzmdqa5/G9vfayX5oVqzv9zVmiaO8ezHZ0os7ADU92nhqMVN71/p6nosFcgtACcUQ5cagyPIdOD/qhGoyfbSa3ZEhpRTOIcixTUX0misotitL8L3cpgLl4D6E0yFhhE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674544417; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=guAH/cOw0v56m2IcaCamWVCWxD+lBjmVEFeXkfrEF64=; b=i4OHZ4DbRPwxdmqSKF+BUpU4O5B4M8jzYM6/kHHOCZuxRPhKbp59CLBTgtXR5T8J+Pf9Yg4Xf1QOF3axLqvyqQc0jq+mzTgeQQp/DBEa1EXvkaDzUbbrAVhQYAiCFF/7Zl+7ZZnY1pNBGIGyorpL7e3Q8g/RIA4f+f3+wUj+n4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1674544417056364.6289797818091; Mon, 23 Jan 2023 23:13:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKDUj-0004A0-Pr; Tue, 24 Jan 2023 02:13:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKDUV-0003So-ID for qemu-devel@nongnu.org; Tue, 24 Jan 2023 02:13:12 -0500 Received: from mail.ispras.ru ([83.149.199.84]) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKDUQ-0002m4-TP for qemu-devel@nongnu.org; Tue, 24 Jan 2023 02:13:08 -0500 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id BF89344C1020; Tue, 24 Jan 2023 07:12:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru BF89344C1020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1674544365; bh=guAH/cOw0v56m2IcaCamWVCWxD+lBjmVEFeXkfrEF64=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=rwOFMEM/6oO06EgHGfLwXSp/tUyuejnas6mChNgNcqLvQ8X+7lDOf5wFauihSqvaP E5uZOwKsp0jTKClQsSBX/B1oztuL7by01/XdivLi2IaqzkoicFzFq6ZvzvQBPpDvQ3 fn0FB8SCTyIxjTMJ9u2yRcgxZQpyuDH+bqIxotB4= Subject: [PATCH v2 4/5] target/avr: fix interrupt processing From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Cc: pavel.dovgalyuk@ispras.ru, mrolnik@gmail.com, philmd@linaro.org, richard.henderson@linaro.org Date: Tue, 24 Jan 2023 10:12:45 +0300 Message-ID: <167454436558.3686700.7820951378493451968.stgit@pasha-ThinkPad-X280> In-Reply-To: <167454434356.3686700.6888237867240722060.stgit@pasha-ThinkPad-X280> References: <167454434356.3686700.6888237867240722060.stgit@pasha-ThinkPad-X280> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ispras.ru) X-ZM-MESSAGEID: 1674544417801100002 Interrupt bit vector has 64 bits, but interrupt vector is found with ctz32 function. This patch replaces it with ctz64. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/avr/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index 156dde4e92..61ab6feb25 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -51,7 +51,7 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_r= equest) } if (interrupt_request & CPU_INTERRUPT_HARD) { if (cpu_interrupts_enabled(env) && env->intsrc !=3D 0) { - int index =3D ctz32(env->intsrc); + int index =3D ctz64(env->intsrc); cs->exception_index =3D EXCP_INT(index); avr_cpu_do_interrupt(cs); =20 @@ -78,7 +78,7 @@ void avr_cpu_do_interrupt(CPUState *cs) if (cs->exception_index =3D=3D EXCP_RESET) { vector =3D 0; } else if (env->intsrc !=3D 0) { - vector =3D ctz32(env->intsrc) + 1; + vector =3D ctz64(env->intsrc) + 1; } =20 if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) {