[v3] ARM: Add support for V8M special registers in GDB stub

[PATCH qemu v3 0/2] ARM: Add support for V8M special registers in GDB stub

Posted by ~dreiss-meta 1 year, 10 months ago

Rebased and updated to use NULL as a sentinel.

David Reiss (2):
  target/arm/gdbstub: Support reading M system registers from GDB
  target/arm/gdbstub: Support reading M security extension registers
    from GDB

 target/arm/cpu.h         |  25 +++-
 target/arm/gdbstub.c     | 241 +++++++++++++++++++++++++++++++++++++++
 target/arm/m_helper.c    |  29 ++---
 tests/lcitool/libvirt-ci |   2 +-
 4 files changed, 277 insertions(+), 20 deletions(-)

-- 
2.34.5

Re: [PATCH qemu v3 0/2] ARM: Add support for V8M special registers in GDB stub

Posted by Peter Maydell 1 year, 10 months ago

On Sat, 4 Feb 2023 at 00:34, ~dreiss-meta <dreiss-meta@git.sr.ht> wrote:
>
> Rebased and updated to use NULL as a sentinel.
>
> David Reiss (2):
>   target/arm/gdbstub: Support reading M system registers from GDB
>   target/arm/gdbstub: Support reading M security extension registers
>     from GDB
>
>  target/arm/cpu.h         |  25 +++-
>  target/arm/gdbstub.c     | 241 +++++++++++++++++++++++++++++++++++++++
>  target/arm/m_helper.c    |  29 ++---
>  tests/lcitool/libvirt-ci |   2 +-

You have an accidental submodule change in here. (It probably crept
in on a rebase -- git's terrible submodule handling makes that very
easy to do by accident.)

I've removed that and applied these changes to target-arm.next;
thanks.

-- PMM

Re: [PATCH qemu v3 0/2] ARM: Add support for V8M special registers in GDB stub

Posted by Peter Maydell 1 year, 10 months ago

On Tue, 7 Feb 2023 at 13:46, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 4 Feb 2023 at 00:34, ~dreiss-meta <dreiss-meta@git.sr.ht> wrote:
> >
> > Rebased and updated to use NULL as a sentinel.
> >
> > David Reiss (2):
> >   target/arm/gdbstub: Support reading M system registers from GDB
> >   target/arm/gdbstub: Support reading M security extension registers
> >     from GDB
> >
> >  target/arm/cpu.h         |  25 +++-
> >  target/arm/gdbstub.c     | 241 +++++++++++++++++++++++++++++++++++++++
> >  target/arm/m_helper.c    |  29 ++---
> >  tests/lcitool/libvirt-ci |   2 +-
>
> You have an accidental submodule change in here. (It probably crept
> in on a rebase -- git's terrible submodule handling makes that very
> easy to do by accident.)
>
> I've removed that and applied these changes to target-arm.next;
> thanks.

...the linux-user target fails to build, though:

/usr/bin/ld: libqemu-arm-linux-user.fa.p/target_arm_gdbstub.c.o: in
function `arm_gdb_get_m_secextreg':
gdbstub.c:(.text+0x41cd): undefined reference to `arm_v7m_get_sp_ptr'

Could you have a look at that, please?

thanks
-- PMM