[Qemu-devel] [PATCH 10/22] char: useless NULL check

Marc-André Lureau posted 22 patches 8 years, 5 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 10/22] char: useless NULL check
Posted by Marc-André Lureau 8 years, 5 months ago
g_strdup(NULL) returns NULL already.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index f47d933828..4b633b9366 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -763,7 +763,7 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon *backend)
     const char *logfile = qemu_opt_get(opts, "logfile");
 
     backend->has_logfile = logfile != NULL;
-    backend->logfile = logfile ? g_strdup(logfile) : NULL;
+    backend->logfile = g_strdup(logfile);
 
     backend->has_logappend = true;
     backend->logappend = qemu_opt_get_bool(opts, "logappend", false);
-- 
2.11.0.295.gd7dffce1c.dirty