From nobody Fri May 3 09:16:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486050891297331.9611442644921; Thu, 2 Feb 2017 07:54:51 -0800 (PST) Received: from localhost ([::1]:57415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZJij-0004iR-2f for importer@patchew.org; Thu, 02 Feb 2017 10:54:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZIx8-0000Rz-2f for qemu-devel@nongnu.org; Thu, 02 Feb 2017 10:05:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZIx4-00032C-SA for qemu-devel@nongnu.org; Thu, 02 Feb 2017 10:05:38 -0500 Received: from mail-pg0-x232.google.com ([2607:f8b0:400e:c05::232]:35794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZIx4-00031q-Ml for qemu-devel@nongnu.org; Thu, 02 Feb 2017 10:05:34 -0500 Received: by mail-pg0-x232.google.com with SMTP id 194so6450972pgd.2 for ; Thu, 02 Feb 2017 07:05:34 -0800 (PST) Received: from localhost.localdomain ([12.45.39.194]) by smtp.gmail.com with ESMTPSA id c204sm59275094pfb.51.2017.02.02.07.05.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2017 07:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=APn5Gpj0GFTMGK6FrI5BXXgQ+TVAGSCy8uQ3k/lbrqA=; b=Glo8flE9atxg0Z4xCbNkwe3U6GgYjnMC1S2vCwvAf9NZGffpipQx2X/piC1iigyKgv EvWB6VXaXAMuPntB3oKv1gE8z/7yb0/x58xDqqai8eM6pguBL11lLOF00MkiXIZnu1q9 u5Klyb99IkGfbbFmHsaUW7+NpDJIamYwaPH/f9OM7Ij1KuYOnuzfVdhYOT3239Qzbc+8 3RTXDcpAVTDlXtS9jGsG/ph6uvjfX/eiWPk/Hr7hZOwiClWnp8VQXBzVV/KRyKHjMZQm 9/gOMhA7bHaBC9sVyeDO5tIhe5uuy41dWFcQfkKnDSB8go+5JXMlZJuQ02hQwNuXhC9O DC2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=APn5Gpj0GFTMGK6FrI5BXXgQ+TVAGSCy8uQ3k/lbrqA=; b=MgyNHEhYE7uW+XuvFZykJ4DdyM+Mu167ObOWwLAMcJW9EBNRlJz4/GOeMLqAHnhVsE QPyHcQuR7e4eWgB3snAG7Y35hlj2Fyr+WDLaJBt2LlvJx2WmdqT8W4fcu56dlZwM3xC+ /MOEOH4JkoHDSFE+9z3/HJVcEww2JC3yshQE5r/U8X1HvTncgm/mRed0JK8E7Awl5ihD KpywRp/a/nMhVuAni73tnIrnMiQcUSWnlYI4owk81FYHD81U1UgjOvQJnHs0FSVtoa18 BR8AozU1TOXrxeu0DuAL2K4uQLfsfYGusgH6zG5z7rPYYgk6pk00AV3tQeQnRmmUtjUV t6qg== X-Gm-Message-State: AIkVDXLy0zYOicDMNqY9f6T9uA+rYZyJ6cLnTu3ISdy3/bMiodWmjVdPuGjoCt2D6YxhIw== X-Received: by 10.84.217.85 with SMTP id e21mr13304676plj.109.1486047933765; Thu, 02 Feb 2017 07:05:33 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 2 Feb 2017 07:05:30 -0800 Message-Id: <20170202150530.1025-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::232 Subject: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The replication feature is a small amount of code, does not require any external library and unless used does not add anything to the guest's attack surface. Since any extra configure option affects maintainability on the other hand and is subject to bit rot, I think there is no need to make it configurable. Signed-off-by: Paolo Bonzini --- Sending as RFC to start discussion because I know Dave Gilbert disagrees. :) Makefile.objs | 2 +- block/Makefile.objs | 2 +- configure | 11 ----------- tests/Makefile.include | 2 +- 4 files changed, 3 insertions(+), 14 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 01cef86..d834906 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -15,7 +15,7 @@ block-obj-$(CONFIG_POSIX) +=3D aio-posix.o block-obj-$(CONFIG_WIN32) +=3D aio-win32.o block-obj-y +=3D block/ block-obj-y +=3D qemu-io-cmds.o -block-obj-$(CONFIG_REPLICATION) +=3D replication.o +block-obj-y +=3D replication.o =20 block-obj-m =3D block/ =20 diff --git a/block/Makefile.objs b/block/Makefile.objs index c6bd14e..fd099a6 100644 --- a/block/Makefile.objs +++ b/block/Makefile.objs @@ -24,7 +24,7 @@ block-obj-$(CONFIG_LIBSSH2) +=3D ssh.o block-obj-y +=3D accounting.o dirty-bitmap.o block-obj-y +=3D write-threshold.o block-obj-y +=3D backup.o -block-obj-$(CONFIG_REPLICATION) +=3D replication.o +block-obj-y +=3D replication.o =20 block-obj-y +=3D crypto.o =20 diff --git a/configure b/configure index 86fd833..0cb124e 100755 --- a/configure +++ b/configure @@ -320,7 +320,6 @@ libssh2=3D"" numa=3D"" tcmalloc=3D"no" jemalloc=3D"no" -replication=3D"yes" =20 # parse CC options first for opt do @@ -1166,10 +1165,6 @@ for opt do ;; --enable-jemalloc) jemalloc=3D"yes" ;; - --disable-replication) replication=3D"no" - ;; - --enable-replication) replication=3D"yes" - ;; *) echo "ERROR: unknown option $opt" echo "Try '$0 --help' for more information" @@ -1402,7 +1397,6 @@ disabled with --disable-FEATURE, default is enabled i= f available: numa libnuma support tcmalloc tcmalloc support jemalloc jemalloc support - replication replication support =20 NOTE: The object files are built at the place where configure is launched EOF @@ -5113,7 +5107,6 @@ echo "NUMA host support $numa" echo "tcmalloc support $tcmalloc" echo "jemalloc support $jemalloc" echo "avx2 optimization $avx2_opt" -echo "replication support $replication" =20 if test "$sdl_too_old" =3D "yes"; then echo "-> Your SDL version is too old - please upgrade to have SDL support" @@ -5711,10 +5704,6 @@ if test "$have_rtnetlink" =3D "yes" ; then echo "CONFIG_RTNETLINK=3Dy" >> $config_host_mak fi =20 -if test "$replication" =3D "yes" ; then - echo "CONFIG_REPLICATION=3Dy" >> $config_host_mak -fi - if test "$have_af_vsock" =3D "yes" ; then echo "CONFIG_AF_VSOCK=3Dy" >> $config_host_mak fi diff --git a/tests/Makefile.include b/tests/Makefile.include index 33b4f88..77dc08f 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -115,7 +115,7 @@ check-unit-y +=3D tests/test-crypto-xts$(EXESUF) check-unit-y +=3D tests/test-crypto-block$(EXESUF) gcov-files-test-logging-y =3D tests/test-logging.c check-unit-y +=3D tests/test-logging$(EXESUF) -check-unit-$(CONFIG_REPLICATION) +=3D tests/test-replication$(EXESUF) +check-unit-y +=3D tests/test-replication$(EXESUF) check-unit-y +=3D tests/test-bufferiszero$(EXESUF) gcov-files-check-bufferiszero-y =3D util/bufferiszero.c check-unit-y +=3D tests/test-uuid$(EXESUF) --=20 2.9.3