From nobody Tue Jul 1 09:32:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486434916846407.181439566521; Mon, 6 Feb 2017 18:35:16 -0800 (PST) Received: from localhost ([::1]:51633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavcg-0004Xb-MC for importer@patchew.org; Mon, 06 Feb 2017 21:35:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavao-0003WO-4h for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caval-0005X3-IJ for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:18 -0500 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:34655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caval-0005Wt-DZ for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:15 -0500 Received: by mail-it0-x243.google.com with SMTP id o185so10989079itb.1 for ; Mon, 06 Feb 2017 18:33:15 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.33.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JHUHkIua3h717kllChKoK6ut8SblYYK0ZdQE8kL95Zc=; b=Uqvpt0fIB5hGnafSdtgaWKpU8IBHgfUAacrAOr+SlbTh/Mfo1ynfNe1gZzLtT6nx4R 4WdUxxlwEAlWL8eT3rJ54Lb6ea8x2l2fIAWhbgOjrBxloMs/sL/+rvpnrihzfqEtQYX0 KJeCXxhbL/05Ym8IzkF3dHYslDnsyecNmtycbSrXcaYUOBRxftkV8hxXp9Uqoyv4Z+EP kvPg449weZffRBqetnZYpVIcvl3YUhc6Su61jiyrALKnCFYOpaTT5ia9W1aKTscqzkba vqXiytnhPlpXyPuSS9BKwEeZXF+6oYbfO1SptgMjMCAtwdMY5b6pLxjYpWZiJj65UmUK Z8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JHUHkIua3h717kllChKoK6ut8SblYYK0ZdQE8kL95Zc=; b=g0Ii+7bcNHjFf1vWKsTA93PZalDqIbNhV57M4nuF6Rko3NbinqG1jZjH7v3EmMCMlX 4sCBehQCj88i5awh2DL6Khzwjlefn6mAoRpPXLZUEcxQ1pm1oCC6hn0Bz3qKCUFjRJOe mUXJTYBa6AIgcGLSoxqLjWO8mklhzyugjDE7yHWwJbjplIQjiqw9yHWRTX9qs+9iZ2Zg MOkbDH6wIKFsAQSnl98fPGn6R08isCYEguOYADuBtP7EhJBzLEW/PSTRoE/tzOj47CNx sz237gPTsbLPlFU50aVdFQV4q+3giYifGuseP9I1m2hDB/BDVfOI4YCk/OBN45TLS9PH IojQ== X-Gm-Message-State: AIkVDXLVIV34CxiOFP6FDGdMmyZkY8KU1T/sJkEdWgrVDqlyAR1jmLC1m1hwhhnmuexsrA== X-Received: by 10.36.43.194 with SMTP id h185mr10507212ita.121.1486434794769; Mon, 06 Feb 2017 18:33:14 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:28 -0800 Message-Id: <20170207023229.29431-5-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::243 Subject: [Qemu-devel] [PULL 4/5] target/hppa: Tidy do_cbranch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Removes some dead code detected by Covarity. Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 4d243f7..5d571f0 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1433,7 +1433,6 @@ static ExitStatus do_cbranch(DisasContext *ctx, targe= t_long disp, bool is_n, target_ulong dest =3D iaoq_dest(ctx, disp); TCGLabel *taken =3D NULL; TCGCond c =3D cond->c; - int which =3D 0; bool n; =20 assert(ctx->null_cond.c =3D=3D TCG_COND_NEVER); @@ -1455,14 +1454,14 @@ static ExitStatus do_cbranch(DisasContext *ctx, tar= get_long disp, bool is_n, n =3D is_n && disp < 0; if (n && use_nullify_skip(ctx)) { nullify_set(ctx, 0); - gen_goto_tb(ctx, which++, ctx->iaoq_n, ctx->iaoq_n + 4); + gen_goto_tb(ctx, 0, ctx->iaoq_n, ctx->iaoq_n + 4); } else { if (!n && ctx->null_lab) { gen_set_label(ctx->null_lab); ctx->null_lab =3D NULL; } nullify_set(ctx, n); - gen_goto_tb(ctx, which++, ctx->iaoq_b, ctx->iaoq_n); + gen_goto_tb(ctx, 0, ctx->iaoq_b, ctx->iaoq_n); } =20 gen_set_label(taken); @@ -1471,23 +1470,17 @@ static ExitStatus do_cbranch(DisasContext *ctx, tar= get_long disp, bool is_n, n =3D is_n && disp >=3D 0; if (n && use_nullify_skip(ctx)) { nullify_set(ctx, 0); - gen_goto_tb(ctx, which++, dest, dest + 4); + gen_goto_tb(ctx, 1, dest, dest + 4); } else { nullify_set(ctx, n); - gen_goto_tb(ctx, which++, ctx->iaoq_b, dest); + gen_goto_tb(ctx, 1, ctx->iaoq_b, dest); } =20 /* Not taken: the branch itself was nullified. */ if (ctx->null_lab) { gen_set_label(ctx->null_lab); ctx->null_lab =3D NULL; - if (which < 2) { - nullify_set(ctx, 0); - gen_goto_tb(ctx, which, ctx->iaoq_b, ctx->iaoq_n); - return EXIT_GOTO_TB; - } else { - return EXIT_IAQ_N_STALE; - } + return EXIT_IAQ_N_STALE; } else { return EXIT_GOTO_TB; } --=20 2.9.3