[v2] chardev clean-ups & tests

[Qemu-devel] [PATCH v2 10/21] char: useless NULL check

Posted by Marc-André Lureau 8 years, 4 months ago

g_strdup(NULL) returns NULL already.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index 558fd8b31c..bb20d73fcf 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -764,7 +764,7 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon *backend)
     const char *logfile = qemu_opt_get(opts, "logfile");
 
     backend->has_logfile = logfile != NULL;
-    backend->logfile = logfile ? g_strdup(logfile) : NULL;
+    backend->logfile = g_strdup(logfile);
 
     backend->has_logappend = true;
     backend->logappend = qemu_opt_get_bool(opts, "logappend", false);
-- 
2.12.0.rc2.3.gc93709801

Re: [Qemu-devel] [PATCH v2 10/21] char: useless NULL check

Posted by Philippe Mathieu-Daudé 8 years, 4 months ago

On 02/27/2017 10:41 AM, Marc-André Lureau wrote:
> g_strdup(NULL) returns NULL already.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  chardev/char.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 558fd8b31c..bb20d73fcf 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -764,7 +764,7 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon *backend)
>      const char *logfile = qemu_opt_get(opts, "logfile");
>
>      backend->has_logfile = logfile != NULL;
> -    backend->logfile = logfile ? g_strdup(logfile) : NULL;
> +    backend->logfile = g_strdup(logfile);
>
>      backend->has_logappend = true;
>      backend->logappend = qemu_opt_get_bool(opts, "logappend", false);
>